Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running multiple Chrome profiles sequentially #55

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

znarfm
Copy link
Contributor

@znarfm znarfm commented Nov 20, 2024

This PR enhances the --profile argument to support running searches across multiple Chrome profiles sequentially.

Changes:

  • Modified --profile argument to accept zero or more profile names
  • Added profile-specific messaging in console output
  • Updated README with the said changes

Example usage:

bing-rewards --profile Default 'Profile 1' 'Profile 2'

@jack-mil
Copy link
Owner

Cool! I don't use Chrome or multiple profiles, so I don't have an easy way to test this. But I will take a look and if it is working well for you, will probably merge.

@znarfm
Copy link
Contributor Author

znarfm commented Nov 20, 2024

Thanks! I use MS Edge and has 3 profiles on my browser, namely "Default", "Profile 1", and "Profile 2". I can say that it works well for me:

  • was able to open the browser
  • search something
  • close the browser
  • and do that for the next two profiles

image

However, I do not use Firefox and any Firefox-based browser so I did not test there. But AFAIK, the current code does not support the profile managing system that Firefox use, since the current code uses --profile-directory={profile} argument for opening the browser, which Firefox does not have.

@jack-mil
Copy link
Owner

Yes, I have never supported Firefox-based browsers, since at the time I could not find a way to launch the Firefox browser with a given user agent string using command line arguments.

@znarfm
Copy link
Contributor Author

znarfm commented Feb 9, 2025

Heya, @jack-mil

I just wanted to follow up on this PR. I have been using this patch using my local changes daily ever since, and I think it is good enough now for general use, and I’d appreciate it if you could take a look when you have a moment.

If you have any feedback or need further adjustments, I’m happy to make any necessary changes.

Thanks again for your time and all the work you do on this project!

Copy link
Owner

@jack-mil jack-mil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I left this so long! Working on merging the backlog today.

bing_rewards/options.py Outdated Show resolved Hide resolved
bing_rewards/__init__.py Outdated Show resolved Hide resolved
@jack-mil jack-mil merged commit bba536e into jack-mil:develop Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants