Skip to content

Conversation

@bruxisma
Copy link
Member

This PR brings several important fixes in addition to the new feature:

  1. Duplicate target and component names are now correctly removed.
  2. We now know we'll need a breaking change fix for find::library, as the HEADER argument fails in all cases where the directory location and package share the same name.
  3. Some internal documentation markdown was fixed.

It is unfortunate that the JACK2 interface, library, and packages are so confusing between Windows and Linux. Very little effort has been done to make it clear that the jack2 API is hidden behind packages like jackd, which have nothing to do with libjack-dev.

Thankfully, it seems we're "one of the first" in this space, as there are effectively no FindJACK2.cmake files on github, and the ones that are provide a simplistic API that will not eventually support:

  • Static Library Preferences
  • Finding the jackd Daemon itself (for launching via tests, I assume)
  • Automatic target importing

bruxisma added 2 commits May 14, 2025 23:56
We can now find the JACK2 libraries as a dependency.

Signed-off-by: Izzy Muerte <[email protected]>
@bruxisma bruxisma changed the title feat(find): add JACK2 find_package module feat(find): add JACK find_package module Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants