Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type member insted of type parameter for Entity and EntityId mapping #8

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gakuzzzz
Copy link

@gakuzzzz gakuzzzz commented Mar 6, 2019

Hi all,

It is unnecessary to use type parameter for Entity and EntityId mapping.
Use of this type argument destroys the encapsulation, so the use of type members is recommended.

Diff indicates that you can write briefly on the user side.

Best regards.

@sp1rytus
Copy link
Contributor

sp1rytus commented Mar 6, 2019

Thanks for your suggestion.
Certainly it is possible to reduce extra declaration by constraining the type of Id with EntityModel.
However, the amount of modification of the existing code also increases,
so we will consider it as a merge to the next ixias v.1.2.x system.
I will merge later.

@sp1rytus sp1rytus force-pushed the develop branch 2 times, most recently from a02583d to 509fd76 Compare October 19, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants