-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: update antfu config to version 5 #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚅 Environment Next-js-Boilerplate-pr-471 in Next.js Boilerplate has no services deployed. |
|
Warning Rate limit exceeded@ixartz has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis PR bumps many runtime and dev dependency versions in the root Changes
Sequence Diagram(s)(omitted — changes are dependency and CI image updates without new runtime control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build with 22.x
- GitHub Check: Build with 24.x
🔇 Additional comments (1)
package.json (1)
52-99: Antfu ESLint config v5 — verifiedeslint.config.mjs imports '@antfu/eslint-config' and exports default antfu(...); package.json has eslint ^9.36.0; no legacy .eslintrc.* files found. Expect rule churn — run eslint --fix locally and in CI.
| "@arcjet/next": "^1.0.0-beta.12", | ||
| "@clerk/localizations": "^3.25.3", | ||
| "@clerk/nextjs": "^6.32.2", | ||
| "@hookform/resolvers": "^5.2.2", | ||
| "@logtape/logtape": "^1.1.1", | ||
| "@sentry/nextjs": "^9.46.0", | ||
| "@t3-oss/env-nextjs": "^0.13.8", | ||
| "drizzle-orm": "^0.44.4", | ||
| "next": "^15.5.0", | ||
| "next-intl": "^4.3.4", | ||
| "drizzle-orm": "^0.44.5", | ||
| "next": "^15.5.4", | ||
| "next-intl": "^4.3.9", | ||
| "pg": "^8.16.3", | ||
| "posthog-js": "^1.260.1", | ||
| "posthog-js": "^1.268.3", | ||
| "react": "19.1.1", | ||
| "react-dom": "19.1.1", | ||
| "react-hook-form": "^7.62.0", | ||
| "zod": "^4.0.17" | ||
| "react-hook-form": "^7.63.0", | ||
| "zod": "^4.1.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Runtime bumps look sane; check peer compatibility (Vite-related)
- Next 15.5.4 + React 19.1.1 + next-intl 4.3.9 + Clerk and drizzle patches are consistent.
- Potential gap: @vitejs/plugin-react@5 and vitest@3 expect Vite ^5 as a peer. I don’t see a direct "vite" devDependency. If Storybook doesn’t hoist Vite, Vitest may warn/fail.
Run this to verify Vite presence and relevant config:
If missing, consider adding:
- devDependency: "vite": "^5.x"
- Keep @vitejs/plugin-react aligned with Vite’s major.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "• Checking for Vite dependency in package.json"
rg -nP '"vite"\s*:' package.json || echo " (no direct vite dep found)"
echo
echo "• Looking for Vite config files"
fd -HI --regex '(^|/)vite\.config\.(js|cjs|mjs|ts|mts)$' -t f | sed 's/^/ - /' || true
echo
echo "• Checking Storybook framework selection"
rg -nP '@storybook/nextjs-vite' -C2 .storybook || echo " (no explicit nextjs-vite framework reference found)"Length of output: 972
Add Vite as a devDependency (Vite v5) — package.json missing 'vite' while Storybook uses nextjs-vite
package.json has no direct "vite" dependency; .storybook/main.ts references "@storybook/nextjs-vite". If Vite isn't hoisted, @vitejs/plugin-react@5 and vitest@3 (peers requiring Vite ^5) will warn/fail. Add devDependency "vite": "^5.x" and align @vitejs/plugin-react / vitest versions to Vite's major. Affected: package.json, .storybook/main.ts.
🤖 Prompt for AI Agents
In package.json around lines 34 to 49, add Vite as a devDependency (e.g. "vite":
"^5.x") because .storybook/main.ts uses "@storybook/nextjs-vite" and peer deps
like @vitejs/plugin-react@5 and vitest@3 require Vite v5; update or align
@vitejs/plugin-react and vitest versions in devDependencies to match Vite's
major (v5) and ensure lockfile is updated (run install) so Storybook and test
tooling resolve without peer warnings; also confirm .storybook/main.ts remains
configured for nextjs-vite.
fedc23e to
3174568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/CI.yml (3)
131-133: Keep Playwright image tags consistent across jobs (use v1.55.1 here too).Mirror the unit-test change for Storybook tests.
Apply:
- uses: docker://mcr.microsoft.com/playwright:v1.55.0 + uses: docker://mcr.microsoft.com/playwright:v1.55.1
157-159: Bump Playwright image for E2E to v1.55.1 for parity with dev dependency.Consistency avoids subtle browser/driver mismatches.
Apply:
- uses: docker://mcr.microsoft.com/playwright:v1.55.0 + uses: docker://mcr.microsoft.com/playwright:v1.55.1
159-159: Typo: “Firebox” → “Firefox”.Minor comment fix.
Apply:
- args: sh -c "HOME=/root npm run test:e2e" # Set HOME to /root to avoid Playwright error with Firebox + args: sh -c "HOME=/root npm run test:e2e" # Set HOME to /root to avoid Playwright error with Firefox
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.github/workflows/CI.yml(3 hunks)README.md(1 hunks)package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- README.md
- package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Run unit tests (22.x)
- GitHub Check: Run E2E tests (22.x)
- GitHub Check: Run Storybook (22.x)
🔇 Additional comments (1)
.github/workflows/CI.yml (1)
103-105: Don't bump Playwright Docker image to v1.55.1 — tag not publishedmcr.microsoft.com/playwright:v1.55.1 is not available; keep docker://mcr.microsoft.com/playwright:v1.55.0 (or use :v1.55.0-jammy to pin OS) and only change the workflow once an official :v1.55.1 image is released.
File: .github/workflows/CI.yml (lines 103–105)
Likely an incorrect or invalid review comment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
========================================
- Coverage 5.72% 5.71% -0.01%
========================================
Files 45 45
Lines 1538 1539 +1
Branches 45 45
========================================
Hits 88 88
- Misses 1422 1423 +1
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 5.1.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
Chores
Tests
Documentation
No breaking changes expected for typical usage.