fix: Use HTTP/1.1 for downloading server #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused (and frustrated) by whatever is going on with curl and Mojang's CDN. That line was just recently changed in #459 to fix an issue with the same symptoms Can you please double check that you are indeed running a version of the image with the change above? Setting While I'm not opposed to accepting this PR with a change to HTTP 1.1, again I'm confused why this seems to be an "unfixed problem" that got "fixed". |
|
Please re-open if you think this was still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, downloads of the Minecraft Bedrock server have failed with the error
curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2). This is due to recent versions ofcurldefaulting to HTTP/2 with invalid header options. The simplest workaround is to revert to HTTP/1.1 for the download request.