619 change log bug fix #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
please put more details into a description. it's unclear what exactly case is fixed and why Pull Request refers to itself though a link "#804 Change log" |
skyboyer
reviewed
Mar 6, 2023
| @@ -304,6 +304,9 @@ export type GetChangeLogType = ChangeLogType & { | |||
| timezoneOffset: number; | |||
| year: number; | |||
| }; | |||
| pagabel?: { | |||
There was a problem hiding this comment.
pagabel? where is it used?
| }; | ||
| const changesPerPage: PageSizeType = [10, 20, 50, 'All']; | ||
|
|
||
| export const ChangeLog: React.FC = () => { |
There was a problem hiding this comment.
plz highlight by commenting which parts have been changed - I assume most of this component has just been extracted from src/views/postUpdation/AllPostTypesUpdation.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of Pull Request *
Related links
Issue link
#804 Change log
Description *
Add pagination