Open
Conversation
Updated certification process to automatic one Removed `v` from operator directory Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
fgiloux
reviewed
Jan 8, 2024
Contributor
fgiloux
left a comment
fgiloux
left a comment
There was a problem hiding this comment.
My personal view is that we should stop publishing olm-for-cilium to the certified operators catalog and publish it to the community catalog instead.
This would however require some proper communication for minimizing disruption to users.
| PFLT_DOCKERCONFIG=~/.docker/config.json preflight check container --pyxis-api-token=$RHCP_PREFLIGHT_API_KEY --submit --certification-project-id=ospid-104ec1da-384c-4d7c-bd27-9dbfd8377f5b scan.connect.redhat.com/ospid-104ec1da-384c-4d7c-bd27-9dbfd8377f5b/cilium-olm:v1.10.0 | ||
| ``` | ||
|
|
||
| Next, login to [Redhat Parnter Connect][] and click "Publish" on the image (once the vulnerability scanning is done). |
Contributor
There was a problem hiding this comment.
I guess you are relying on
olm-for-cilium/.github/workflows/publish.yaml
Lines 56 to 65 in d08076c
|
|
||
| Once the image is published open a new PR in the [isovalent/certified-operators-cilium](https://github.com/isovalent/certified-operators-cilium), by adding the | ||
| new manifests to the appropriately named new directory under `operators/cilium` (`operators/cilium/v1.14.3`, for example). | ||
| new manifests to the appropriately named new directory under `operators/cilium` (`operators/cilium/1.14.3`, for example). |
Contributor
There was a problem hiding this comment.
What is the rational for removing the "v"? It is also present under bundles and manifests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated certification process to automatic one
Removed
vfrom operator directory