add client pointers runtime #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykWalach
force-pushed
the
client-pointers-runtime
branch
from
83e3ab7 to
11441a8
Compare
PatrykWalach
force-pushed
the
client-pointers-runtime
branch
from
11441a8 to
a2c5f37
Compare
PatrykWalach
force-pushed
the
client-pointers-runtime
branch
from
a2c5f37 to
edcea94
Compare
rbalicki2
approved these changes
May 24, 2025
| @@ -797,6 +798,104 @@ export function readLinkedFieldData( | |||
| }; | |||
| } | |||
| const targetId = link; | |||
| if (typeof field.refetchQuery === 'number') { | |||
| root = link; | |||
There was a problem hiding this comment.
nit: this is a bit confusing. Maybe it will be a bit clearer to define a new variable, clientPointerTargetId or somthing?
There was a problem hiding this comment.
well, we have that with targetId already!
| @@ -797,6 +798,104 @@ export function readLinkedFieldData( | |||
| }; | |||
| } | |||
| const targetId = link; | |||
| if (typeof field.refetchQuery === 'number') { | |||
There was a problem hiding this comment.
nit: refetchQuery != null I think is more idiomatic
can you add a comment saying // if refetchQuery is not null, then the field is a client pointer. Can you also add that to ReaderLinkedField?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add support for lists as a follow up
Part of #53