Draft
Conversation
- Add Model class with LoadModel() and Forward() stubs - Add IsPyTorchRuntimeEnabled() compile-time check - Add OPEN3D_BUILD_PYTORCH_OPS compile definition Part of: Enable 3DML processing in C++
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
2 tasks
Member
|
Hi @xiaoya27 thanks for picking this up! This is awesome! We already have DLPack support, so you should be able to skip this. Also, since the roadmap discussion, PyTorch has released executorch which is specifically designed for deployment (inference). This is quite a bit lighter than full PyTorch, while being compatible with PyTorch checkpoints. We should switch to executorch for Open3D. |
Author
|
Thanks @ssheorey! ExecuTorch makes a lot of sense here given its focus on lean inference. I'd like to clarify the integration strategy:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
This is part of the #6778 initiative and part of the roadmap in the discussion . It adds the foundational
open3d::ml::Modelclass that will allow loading PyTorch models exported via AOTInductor for C++ inference.This PR establishes the API skeleton. Follow-up PRs will implement:
Checklist:
python util/check_style.py --applyto apply Open3D code style to my code.Description
Adds
open3d::ml::Modelclass with:LoadModel(path)- stub for loading model artifactsForward(inputs)- stub for running inferenceIsPyTorchRuntimeEnabled()- compile-time check forBUILD_PYTORCH_OPSOPEN3D_BUILD_PYTORCH_OPScompile definitionUnit tests included for basic API validation.