Adding minimum volume oriented bounding ellipsoid matching functionality#7377
Open
quentin-leboutet wants to merge 13 commits intomainfrom
Open
Adding minimum volume oriented bounding ellipsoid matching functionality#7377quentin-leboutet wants to merge 13 commits intomainfrom
quentin-leboutet wants to merge 13 commits intomainfrom
Conversation
…t/OrientedBoundingEllipsoid
…t/OrientedBoundingEllipsoid
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Pull request overview
This PR adds Oriented Bounding Ellipsoid (OBE) support to Open3D, implementing minimum volume enclosing ellipsoids using Khachiyan's algorithm. The feature provides a tighter geometric approximation than axis-aligned or oriented bounding boxes for certain shapes.
Key changes:
- Implements Khachiyan's algorithm for computing minimum volume enclosing ellipsoids
- Adds OrientedBoundingEllipsoid class to both legacy and tensor-based APIs
- Integrates ellipsoid support across all 3D geometry types with visualization capabilities
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/open3d/t/geometry/kernel/MinimumOBE.cpp | Core Khachiyan algorithm implementation for computing minimum volume ellipsoids |
| cpp/open3d/geometry/BoundingVolume.h/cpp | Legacy API OrientedBoundingEllipsoid class with transformation operations |
| cpp/open3d/t/geometry/BoundingVolume.h/cpp | Tensor-based OrientedBoundingEllipsoid implementation |
| cpp/open3d/geometry/TriangleMeshFactory.cpp | CreateEllipsoid factory method for generating ellipsoid meshes |
| cpp/open3d/geometry/LineSetFactory.cpp | Factory method for creating wireframe representation of ellipsoids |
| cpp/pybind/geometry/boundingvolume.cpp | Python bindings for OrientedBoundingEllipsoid |
| cpp/open3d/visualization/* | Visualization support for rendering ellipsoids |
| cpp/tests/t/geometry/TriangleMesh.cpp | Unit test for CreateEllipsoid functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Oriented Bounding Ellipsoid (OBE) support to Open3D
Type
Motivation and Context
This PR adds support for Oriented Bounding Ellipsoids (OBE) to Open3D, complementing the existing bounding volume primitives (AABB and OBB). Oriented bounding ellipsoids provide a tighter fit for certain geometries compared to boxes, which can be beneficial for:
The implementation uses Khachiyan's algorithm to compute the minimum volume enclosing ellipsoid, providing an efficient approximation of the optimal bounding ellipsoid.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Core Implementation
New Classes:
Key Features:
GetOrientedBoundingEllipsoid()method to all 3D geometry base classes (Geometry3D.h:74-75)create_from_points()static method with robust optioncenter,R(rotation),radii,colorTry it: