Skip to content

only compile ExtractZIP when WITH_MINIZIP is enabled #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

only compile ExtractZIP when WITH_MINIZIP is enabled #7252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e97378b
enable MiniZIP by default
christianrauch May 28, 2025
1385449
only compile ExtractZIP when WITH_MINIZIP is enabled
christianrauch Feb 22, 2025
b3a105f
disable minizip support when not available
christianrauch Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion 3rdparty/find_dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,12 @@ if(WITH_MINIZIP)
open3d_pkg_config_3rdparty_library(3rdparty_minizip
SEARCH_ARGS minizip
)
list(APPEND Open3D_3RDPARTY_PRIVATE_TARGETS_FROM_SYSTEM Open3D::3rdparty_minizip)
if(3rdparty_minizip_FOUND)
list(APPEND Open3D_3RDPARTY_PRIVATE_TARGETS_FROM_SYSTEM Open3D::3rdparty_minizip)
else()
message(WARNING "Minizip no found. Support will be disabled.")
set(WITH_MINIZIP OFF)
endif()
endif()

# Googletest
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ else()
endif()

option(PREFER_OSX_HOMEBREW "Prefer Homebrew libs over frameworks" ON )
option(WITH_MINIZIP "Enable MiniZIP" OFF)
option(WITH_MINIZIP "Enable MiniZIP" ON )

# Sensor options
option(BUILD_LIBREALSENSE "Build support for Intel RealSense camera" OFF)
Expand Down
8 changes: 7 additions & 1 deletion cpp/open3d/utility/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ target_sources(utility PRIVATE
Download.cpp
Eigen.cpp
Extract.cpp
ExtractZIP.cpp
FileSystem.cpp
Helper.cpp
IJsonConvertible.cpp
Expand All @@ -19,6 +18,13 @@ target_sources(utility PRIVATE
Timer.cpp
)

if (WITH_MINIZIP)
target_sources(utility PRIVATE
ExtractZIP.cpp
)
target_compile_definitions(utility PRIVATE HAS_MINIZIP)
endif()

if (BUILD_ISPC_MODULE)
target_sources(utility PRIVATE
ISAInfo.ispc
Expand Down
4 changes: 4 additions & 0 deletions cpp/open3d/utility/Extract.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

#include <unordered_map>

#ifdef HAS_MINIZIP
#include "open3d/utility/ExtractZIP.h"
#endif
#include "open3d/utility/FileSystem.h"
#include "open3d/utility/Logging.h"

Expand All @@ -20,7 +22,9 @@ static const std::unordered_map<
std::string,
std::function<void(const std::string&, const std::string&)>>
file_extension_to_extract_function{
#if HAS_MINIZIP
{"zip", ExtractFromZIP},
#endif
};

bool IsSupportedCompressedFilePath(const std::string& file_path) {
Expand Down
Loading