create proper docs website#37
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a brand new, comprehensive documentation website for the CalcFlow project. The documentation is designed to be a central resource for understanding CalcFlow's core principles, learning how to use its various features for parsing quantum chemistry outputs and generating inputs, and guiding developers on contributing to the library. It aims to make the project more accessible and easier to navigate for all users, from beginners to advanced contributors. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive documentation website for the CalcFlow library, built with zensical. It includes detailed guides for users and developers, covering everything from parsing outputs and building inputs to the internal architecture and testing strategies. The changes also correctly update the project's dependencies and .gitignore to support the new documentation build process. The documentation is well-written and structured. I have one suggestion to improve the file handling in code examples for better robustness and consistency.
Greptile Summary
This PR introduces a proper documentation website for CalcFlow by adding a full
docs/directory of Markdown pages, azensical.tomlsite configuration, and a GitHub Actions workflow to build and deploy the site to GitHub Pages on every push tomaster/main. The.gitignoreis updated to stop ignoringdocs/and*.mdfiles (both previously excluded) and instead ignore thesite/build output.Key changes:
zensical.tomlconfigures the site name, nav structure, theme (light/dark/auto palettes with Lucide icons), and fonts.github/workflows/docs.ymldeploys the built site to GitHub Pages via the standardupload-pages-artifact/deploy-pagesaction pairpyproject.toml/uv.lockaddzensical>=0.0.26to dev dependencies with its transitive deps pinned in the lockfileTwo style issues were found in the CI workflow: the
pip install zensicalstep is unpinned (inconsistent with theuv.lockpin used everywhere else in the repo), and there is noconcurrencygroup to prevent overlapping Pages deployments on rapid pushes.Confidence Score: 4/5
Important Files Changed
pip install zensical(inconsistent withuv.lock) and missing concurrency group to prevent overlapping deployments.docs/and*.mdignore rules (docs now live in the repo) and addedsite/to ignore the zensical build output; clean and correct change.zensical>=0.0.26to dev dependencies; no issues.CalculationInputobjects; covers TDDFT, solvation, MOM, RI approximations, and exporting; all setter signatures match the described API.SlurmJobfor generating HPC submission scripts; code examples are self-consistent and complete.uv run --with calcflowpattern is accurate; the Hartree→eV conversion uses 27.211 (an approximation), which is acceptable in documentation examples.MullikenChargesParserexample are consistent with the documentedAGENTS.mdparser conventions.AGENTS.md.schema_version, how to write sequential migrations, and forward-incompatibility detection; consistent with the versioning rules inAGENTS.md.zensical==0.0.26and its transitive dependencies (click,deepmerge,markdown,pymdown-extensions,pyyaml); no issues.Sequence Diagram
sequenceDiagram participant GH as GitHub (push to master) participant CI as docs.yml workflow participant Pages as GitHub Pages API participant Site as Live Docs Site GH->>CI: trigger on push CI->>CI: configure-pages CI->>CI: checkout@v5 CI->>CI: setup-python@v5 CI->>CI: pip install zensical CI->>CI: zensical build --clean → site/ CI->>Pages: upload-pages-artifact (path: site/) Pages-->>CI: artifact ID CI->>Pages: deploy-pages Pages-->>CI: page_url Pages->>Site: publish new docs buildPrompt To Fix All With AI
Last reviewed commit: 8d9cad8