Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sort function #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add sort function #8

wants to merge 4 commits into from

Conversation

rmacciuci
Copy link

No description provided.

@isacikgoz isacikgoz requested a review from yakuter March 30, 2022 06:58
@isacikgoz isacikgoz added the enhancement New feature or request label Mar 30, 2022
@isacikgoz
Copy link
Owner

@rmacciuci Thanks for the contribution 🚀 Would you mind a brief PR description for future documentation? Thanks!

@yakuter
Copy link
Collaborator

yakuter commented Mar 30, 2022

Also @rmacciuci some extra tests would be nice for string and structs sorting (by struct field). This way we can show people how to use this function.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #8 (093129b) into master (cb0e5d9) will increase coverage by 1.05%.
The diff coverage is 100.00%.

❗ Current head 093129b differs from pull request most recent head 69d526e. Consider uploading reports for the commit 69d526e to get more accurate results

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   95.00%   96.05%   +1.05%     
==========================================
  Files           1        1              
  Lines          60       76      +16     
==========================================
+ Hits           57       73      +16     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
slices.go 96.05% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0e5d9...69d526e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants