WASM: change Language to be a proper TypeScript enum
#5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
force-pushed
the
andrea/wasm-langauge-enum-fix
branch
from
28c94d1 to
6b5051d
Compare
patnir
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation makes
Languagea "string enum", however such enums do not get properly translated to Javascript/Typescript, in the sense that on the JS/TS side you cannot writeLanguage.English, but you must write"en".This PR changes
Languageto be a regular enum instead, so that the code on the JS/TS side is more clear, and in particular type-checking can find invalid enum values.Testing Plan
Unit tests