Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reads identity from Ledger in DKG round3 #5718

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

hughy
Copy link
Contributor

@hughy hughy commented Feb 4, 2025

Summary

when running DKG using a Ledger device we must use the identity from the Ledger

reads the identity from the Ledger device during DKG round3 instead of from the walletDB when using the '--ledger' flag in 'wallet:multisig:dkg:create' and 'wallet:multisig:dkg:round3'

Closes IFL-3170
Closes IFL-3171

Testing Plan

  • create multisig account using wallet:multisig:dkg:create
  • create multisig account using separate dkg commands:
    • wallet:multisig:participant:create
    • wallet:multisig:dkg:round1
    • wallet:multisig:dkg:round2
    • wallet:multisig:dkg:round3

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

when running DKG using a Ledger device we must use the identity from the Ledger

reads the identity from the Ledger device during DKG round3 instead of from the
walletDB when using the '--ledger' flag in 'wallet:multisig:dkg:create' and
'wallet:multisig:dkg:round3'

Closes IFL-3170
Closes IFL-3171
@hughy hughy requested a review from a team as a code owner February 4, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant