getAccountsTransactions.test: Removed sort from streams back transactions for a given block sequence range

[j-s-n]

Summary

Removed the sort for the accountTransactions since it is already received in order. I regenerated the fixtures and the random hash lexographically sorted ended up swapping the order of the transactions.

Testing Plan

I regenerated fixtures without sort and test passed

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
N/A

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.
N/A

[hughy]

I'm wondering if we should sort both accountTransactionHashes and blockTransactionHashes before comparing. This test seems more concerned with all of the transactions being present than it is with all of them being in the same order as they are on the blocks.

[j-s-n]

I'm wondering if we should sort both accountTransactionHashes and blockTransactionHashes before comparing. This test seems more concerned with all of the transactions being present than it is with all of them being in the same order as they are on the blocks.

loadTransactionsBySequence range returns the transactions in the sequence order, so we can omit the sort since the hard coded blockTransactionHashes are also in sequence order.

[hughy]

I'm wondering if we should sort both accountTransactionHashes and blockTransactionHashes before comparing. This test seems more concerned with all of the transactions being present than it is with all of them being in the same order as they are on the blocks.

loadTransactionsBySequence range returns the transactions in the sequence order, so we can omit the sort since the hard coded blockTransactionHashes are also in sequence order.

Sounds good to me!