Skip to content

Commit

Permalink
uses multisigAccountPrompt in signing commands
Browse files Browse the repository at this point in the history
replaces 'multisigSecretPrompt' with 'multisigAccountPrompt' in
'wallet:multisig:commitment:create' and 'wallet:multisig:signature:create'.

renames 'participantName' variable to 'accountName' since this refers to the
name of an imported account

Closes IFL-3174
Closes IFL-3175
  • Loading branch information
hughy committed Feb 6, 2025
1 parent 76d47a5 commit 86dbd79
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions ironfish-cli/src/commands/wallet/multisig/commitment/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ export class CreateSigningCommitmentCommand extends IronfishCommand {
const client = await this.connectRpc()
await ui.checkWalletUnlocked(client)

let participantName = flags.account
if (!participantName) {
participantName = await ui.multisigSecretPrompt(client)
let accountName = flags.account
if (!accountName) {
accountName = await ui.multisigAccountPrompt(client)
}

let identities = options.identity
Expand Down Expand Up @@ -88,7 +88,7 @@ export class CreateSigningCommitmentCommand extends IronfishCommand {
await renderUnsignedTransactionDetails(
client,
unsignedTransaction,
participantName,
accountName,
this.logger,
)

Expand All @@ -100,7 +100,7 @@ export class CreateSigningCommitmentCommand extends IronfishCommand {
}

const response = await client.wallet.multisig.createSigningCommitment({
account: participantName,
account: accountName,
unsignedTransaction: unsignedTransactionInput,
signers: identities.map((identity) => ({ identity })),
})
Expand Down
10 changes: 5 additions & 5 deletions ironfish-cli/src/commands/wallet/multisig/signature/create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ export class CreateSignatureShareCommand extends IronfishCommand {
const client = await this.connectRpc()
await ui.checkWalletUnlocked(client)

let participantName = flags.account
if (!participantName) {
participantName = await ui.multisigSecretPrompt(client)
let accountName = flags.account
if (!accountName) {
accountName = await ui.multisigAccountPrompt(client)
}

let signingPackageString = options.signingPackage
Expand All @@ -66,7 +66,7 @@ export class CreateSignatureShareCommand extends IronfishCommand {
await renderUnsignedTransactionDetails(
client,
unsignedTransaction,
participantName,
accountName,
this.logger,
)

Expand All @@ -83,7 +83,7 @@ export class CreateSignatureShareCommand extends IronfishCommand {
}

const signatureShareResponse = await client.wallet.multisig.createSignatureShare({
account: participantName,
account: accountName,
signingPackage: signingPackageString,
})

Expand Down

0 comments on commit 86dbd79

Please sign in to comment.