Update V4 RELEASE.md #2992
Update V4 RELEASE.md #2992
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis commit updates the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
RELEASE.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Run Unit Tests
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
RELEASE.md (2)
1-7: New Version Header and Release Notes SectionThe new version header (
# v4.0.0) and "Release Notes" introduction are clearly added. Please verify that the Cosmos-SDK upgrade version mentioned here (v0.50.11-lsm) is correct and consistent throughout the document.
23-27: New Contributors and Full Changelog SectionThe addition of the "New Contributors" section and the full changelog link is a great enhancement for acknowledging contributions and providing context for changes. Ensure that the contributor handle and URLs are correct.
RELEASE.md
Outdated
| ## What's Changed | ||
|
|
||
| * refactor: bump up irismod by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2950> | ||
| * feat: upgrade to v4 by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2963> | ||
| * Upgrade cosmos-sdk in irishub to v0.50.10 by @wangjiulian in <https://github.com/irisnet/irishub/pull/2975> | ||
| * feat: add v4 upgrade plan by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2982> | ||
| * update simulation test by @wangjiulian in <https://github.com/irisnet/irishub/pull/2983> | ||
| * Update dependencies by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2985> | ||
| * chore(Dockerfile): update dockerfile by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2986> | ||
| * fix: prioritize upgrade module in module manager by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2987> | ||
| * fix: fix start command by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2988> | ||
| * chore: update ethermint by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2989> | ||
| * update irismod service mod by @wangjiulian in <https://github.com/irisnet/irishub/pull/2990> | ||
| * fix: fix query txs error by @wangjiulian in <https://github.com/irisnet/irishub/pull/2991> | ||
| * deps: update go.mod by @dreamer-zq in <https://github.com/irisnet/irishub/pull/2993> | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Detailed "What's Changed" Section with Inconsistency Check
The bullet list in the "What's Changed" section provides clear and detailed updates for this release. However, note that line 11 states "* Upgrade cosmos-sdk in irishub to v0.50.10" which conflicts with the release note in line 5 referencing v0.50.11-lsm. Please verify and update the version information to ensure consistency.
Below is a shell script to inspect the relevant parts of the RELEASE.md file. This script will print the header (which may contain the reference to v0.50.11‑lsm) and the "What's Changed" section (which shows v0.50.10) and then search for both version strings. This will help verify whether there’s an inconsistency that needs to be resolved.
Next Steps:
Once you run the script, please review the outputs. If the header (or another section) indeed shows v0.50.11-lsm while the "What's Changed" section shows v0.50.10, update the version information to be consistent across the file.
🏁 Script executed:
#!/bin/bash
# Display header lines (lines 1-6) to check for any version reference like "v0.50.11-lsm"
echo "Header lines (1-6) of RELEASE.md:"
sed -n '1,6p' RELEASE.md
echo "------------------------------"
# Display the "What's Changed" section (lines 7-22) from the file
echo "'What's Changed' section (lines 7-22):"
sed -n '7,22p' RELEASE.md
echo "------------------------------"
# Search for any mention of cosmos-sdk with the '-lsm' version (v0.50.11-lsm)
echo "Searching for 'v0.50.11-lsm' in RELEASE.md:"
grep "v0.50.11-lsm" -n RELEASE.md || echo "No 'v0.50.11-lsm' found."
echo "------------------------------"
# Search for cosmos-sdk version 0.50.10 in RELEASE.md
echo "Searching for 'v0.50.10' in RELEASE.md:"
grep "v0.50.10" -n RELEASE.md || echo "No 'v0.50.10' found."
echo "------------------------------"Length of output: 2478
Action Required: Align Cosmos-SDK Version Across RELEASE.md
Please update the "What's Changed" section to ensure consistency with the header. The header (line 3) indicates the Cosmos-SDK upgrade is to v0.50.11-lsm, while the bullet on line 11 currently states v0.50.10. Update the version in the bullet list to match the header version to avoid confusion.
Summary by CodeRabbit