gaunt/subtle-encoding/tai64: Remove failure
#245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These crates weren't getting much value out of `failure`, and the use of proc macros to generate what is effectively a match statement on enum variants which returns a string literal adds a lot to compile times. Furthermore, `failure` is still using the non-1.0 proc macro crates. It seems there's upstream work to get this fixed[1], but since we're not really getting value out of the proc macros as-is, there's not much reason to bother. [1]: rust-lang-deprecated/failure#319
tarcieri
force-pushed
the
remove-failure
branch
from
3e297cf to
b63b98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These crates weren't getting much value out of
failure, and the use of proc macros to generate what is effectively a match statement on enum variants which returns a string literal adds a lot to compile times.Furthermore,
failureis still using the non-1.0 proc macro crates. It seems there's upstream work to get this fixed1, but since we're not really getting value out of the proc macros as-is, there's not much reason to bother.