-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 'prost' version to 0.11 #152
Conversation
Ping @vmx :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do version bumps during the release, so reverting that commit would be nice.
We didn't upgrade to prost
0.11 as it doesn't bundle protoc
anymore. I think there's some alternative that does that. So either leave it at 0.10
, or dig into the alternative :)
e1990c6
to
3b16d3e
Compare
I used the recommended |
This now uses protobuf-src to vendor protoc
3b16d3e
to
b09b51d
Compare
As you mention downstream crates. Please be aware that this implementation of DAG-PB is currently not spec compliant. The tracking issue is |
sorry, how is that bug relevant here? |
Sorry, copy and paste failure, I've meant #139. |
I still don't understand - this PR is not changing any behavior, just trying to reduce dependencies duplicates. |
My comment was related directly to this PR. It was just a note, that users that use DAG-PB should be aware that the current implementation isn't spec compliant. As you are interested in reducing duplicated dependencies, I thought it would be appropriate to mention that. |
Does anyone know how to fix the Windows CI, so that it can compile protoc? |
Looks like it's blocked on |
As |
Closing in favor of #161 |
This helps downstream crates to not have duplicate version of 'hashbrown'