Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: It is recommended to use the fmt.Errorf method with parameters instead of the errors.New method without parameters. #10643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/commands/p2p.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Example:
allowCustom, _ := req.Options[allowCustomProtocolOptionName].(bool)

if !allowCustom && !strings.HasPrefix(string(proto), P2PProtoPrefix) {
return errors.New("protocol name must be within '" + P2PProtoPrefix + "' namespace")
return fmt.Errorf("protocol name must be within '" + P2PProtoPrefix + "' namespace")
}

return forwardLocal(n.Context(), n.P2P, n.Peerstore, proto, listen, targets)
Expand All @@ -154,7 +154,7 @@ func parseIpfsAddr(addr string) (*peer.AddrInfo, error) {
return nil, err
}
if len(addrs) == 0 {
return nil, errors.New("fail to resolve the multiaddr:" + multiaddr.String())
return nil, fmt.Errorf("fail to resolve the multiaddr:" + multiaddr.String())
}
var info peer.AddrInfo
for _, addr := range addrs {
Expand Down Expand Up @@ -228,7 +228,7 @@ Example:
reportPeerID, _ := req.Options[reportPeerIDOptionName].(bool)

if !allowCustom && !strings.HasPrefix(string(proto), P2PProtoPrefix) {
return errors.New("protocol name must be within '" + P2PProtoPrefix + "' namespace")
return fmt.Errorf("protocol name must be within '" + P2PProtoPrefix + "' namespace")
}

_, err = n.P2P.ForwardRemote(n.Context(), proto, target, reportPeerID)
Expand Down