Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim GUI team members #91

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Trim GUI team members #91

merged 1 commit into from
Oct 2, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Sep 29, 2024

Removes people no longer contributing to the projects to be kinder to their inboxes.

Please comment below if you'd still like to be on this team.

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Removes people no longer contributing to the projects.

- @alanshaw
- @Gozala
- @olizilla
- @whizzzkid
- @tinytb
- @ericronne

Please comment below if you'd still like to be on this team.
@achingbrain achingbrain requested review from a team as code owners September 29, 2024 09:13
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User alanshaw:
  - will lose push permission to cohosting
  - will lose admin permission to demo-ipfs-id-qr-codes
  - will lose admin permission to demo-ipfs-todo
  - will lose admin permission to i18n
  - will lose admin permission to ipfs-cohost
  - will lose admin permission to ipfs-css
  - will lose admin permission to ipfs-dag-builder-vis
  - will lose admin permission to ipfs-deploy
  - will lose admin permission to ipfs-or-gateway
  - will lose push permission to ipfs-provider
  - will lose push permission to ipfs-service-worker-demos
  - will lose admin permission to ipfs-share-files
  - will lose admin permission to ipscend
  - will lose push permission to js-ipld-fixtures
  - will lose admin permission to js-pinning-service-http-client
  - will lose admin permission to pinning-service-compliance
User ericronne:
  - will lose push permission to cohosting
  - will lose admin permission to demo-ipfs-id-qr-codes
  - will lose admin permission to demo-ipfs-todo
  - will lose admin permission to i18n
  - will lose admin permission to ipfs-cohost
  - will lose admin permission to ipfs-css
  - will lose admin permission to ipfs-dag-builder-vis
  - will lose admin permission to ipfs-deploy
  - will lose push permission to ipfs-geoip
  - will lose admin permission to ipfs-or-gateway
  - will lose push permission to ipfs-provider
  - will lose push permission to ipfs-service-worker-demos
  - will lose admin permission to ipfs-share-files
  - will lose pull permission to ipfsx
  - will lose admin permission to ipscend
  - will lose push permission to js-ipld-fixtures
  - will lose admin permission to js-pinning-service-http-client
  - will lose admin permission to pinning-service-compliance
User gozala:
  - will lose push permission to cohosting
  - will lose admin permission to demo-ipfs-id-qr-codes
  - will lose admin permission to demo-ipfs-todo
  - will lose admin permission to i18n
  - will lose admin permission to ipfs-cohost
  - will lose admin permission to ipfs-css
  - will lose admin permission to ipfs-dag-builder-vis
  - will lose admin permission to ipfs-deploy
  - will lose admin permission to ipfs-or-gateway
  - will lose push permission to ipfs-provider
  - will lose push permission to ipfs-service-worker-demos
  - will lose admin permission to ipfs-share-files
  - will lose pull permission to ipfsx
  - will lose admin permission to ipscend
  - will lose push permission to js-ipld-fixtures
  - will lose admin permission to js-pinning-service-http-client
  - will lose admin permission to pinning-service-compliance
User olizilla:
  - will lose admin permission to i18n
  - will lose push permission to ipfs-geoip
  - will lose push permission to js-ipld-fixtures
  - will lose admin permission to js-pinning-service-http-client
  - will lose admin permission to pinning-service-compliance
User tinytb:
  - will lose push permission to cohosting
  - will lose admin permission to demo-ipfs-id-qr-codes
  - will lose admin permission to demo-ipfs-todo
  - will lose admin permission to i18n
  - will lose admin permission to ipfs-cohost
  - will lose admin permission to ipfs-css
  - will lose admin permission to ipfs-dag-builder-vis
  - will lose admin permission to ipfs-deploy
  - will lose push permission to ipfs-geoip
  - will lose admin permission to ipfs-or-gateway
  - will lose push permission to ipfs-provider
  - will lose push permission to ipfs-service-worker-demos
  - will lose admin permission to ipfs-share-files
  - will lose pull permission to ipfsx
  - will lose admin permission to ipscend
  - will lose push permission to js-ipld-fixtures
  - will lose admin permission to js-pinning-service-http-client
  - will lose admin permission to pinning-service-compliance
User whizzzkid:
  - will lose push permission to cohosting
  - will lose admin permission to demo-ipfs-id-qr-codes
  - will lose admin permission to demo-ipfs-todo
  - will lose admin permission to i18n
  - will lose admin permission to ipfs-cohost
  - will lose admin permission to ipfs-css
  - will lose admin permission to ipfs-dag-builder-vis
  - will lose admin permission to ipfs-deploy
  - will lose admin permission to ipfs-or-gateway
  - will lose push permission to ipfs-provider
  - will lose push permission to ipfs-service-worker-demos
  - will lose admin permission to ipfs-share-files
  - will lose pull permission to ipfsx
  - will lose admin permission to ipscend
  - will lose admin permission to js-pinning-service-http-client

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-shipyard

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  - destroy

Terraform will perform the following actions:

  # github_team_membership.this["gui:alanshaw"] will be destroyed
  # (because key ["gui:alanshaw"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"4434f994365a679fa80dc2ac17460f9f6a7f8cdc86b6f56cf50af6c06a5fa65e\"" -> null
      - id       = "2593761:alanshaw" -> null
      - role     = "member" -> null
      - team_id  = "2593761" -> null
      - username = "alanshaw" -> null
    }

  # github_team_membership.this["gui:ericronne"] will be destroyed
  # (because key ["gui:ericronne"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"a1e78f6e7481c186d453a6b3eb6b688b05591906c9b273cc3f4be39d8013dd10\"" -> null
      - id       = "2593761:ericronne" -> null
      - role     = "member" -> null
      - team_id  = "2593761" -> null
      - username = "ericronne" -> null
    }

  # github_team_membership.this["gui:gozala"] will be destroyed
  # (because key ["gui:gozala"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"dd7c654e711c3dafbdd3311f4ef7a8e5358159df02e0c420caf034eafdd742a6\"" -> null
      - id       = "2593761:Gozala" -> null
      - role     = "member" -> null
      - team_id  = "2593761" -> null
      - username = "Gozala" -> null
    }

  # github_team_membership.this["gui:olizilla"] will be destroyed
  # (because key ["gui:olizilla"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"822bf41c2fbfa7d85467fffc33524fb0e612ebade43ad0f184da5af49c86e86e\"" -> null
      - id       = "2593761:olizilla" -> null
      - role     = "maintainer" -> null
      - team_id  = "2593761" -> null
      - username = "olizilla" -> null
    }

  # github_team_membership.this["gui:tinytb"] will be destroyed
  # (because key ["gui:tinytb"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"d31aac6f44f260534bd9a0c5198e072e646a781c0130725b74c0360a9eb9c7ff\"" -> null
      - id       = "2593761:tinytb" -> null
      - role     = "member" -> null
      - team_id  = "2593761" -> null
      - username = "tinytb" -> null
    }

  # github_team_membership.this["gui:whizzzkid"] will be destroyed
  # (because key ["gui:whizzzkid"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"c65185cbaeb5d0ee3c5f28df6ec7f8235f7eadb94f19f6d8234d654f299f1d88\"" -> null
      - id       = "2593761:whizzzkid" -> null
      - role     = "member" -> null
      - team_id  = "2593761" -> null
      - username = "whizzzkid" -> null
    }

Plan: 0 to add, 0 to change, 6 to destroy.

@whizzzkid
Copy link
Contributor

Thanks @achingbrain for being considerate, I don't mind getting these emails. I actually like keeping in touch with what's happening here. I would like to be on this team!

🙏🏽

@achingbrain
Copy link
Member Author

achingbrain commented Sep 29, 2024

Part of the concern is that if people are no longer contributing to the repos here (it happens!), by remaining on these teams they retain significant access rights which increases the potential surface area for supply chain attacks.

If you wish to receive notifications of issues, PRs and releases to keep in touch you can do so by configuring GH to send them to you, but there's no need to also have maintainer and/or admin access to those repos by the principle of least privilege access.

I hope you understand.

@lidel lidel merged commit 77ac560 into master Oct 2, 2024
6 checks passed
@lidel lidel deleted the fix/trim-gui-team-members branch October 2, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants