This repository was archived by the owner on Jun 7, 2023. It is now read-only.
fix: Use yarn for scripts and ensure TAURI_CONFIG_DIR is defined #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/iota/spark-wallet/1lty9caqv |
rihardsgravis
approved these changes
Dec 22, 2019
rihardsgravis
suggested changes
Dec 22, 2019
| @@ -6,8 +6,8 @@ | |||
| "dev": "ts-node --project tsconfig.server.json index.ts", | |||
| "run:ios": "yarn build && cap copy && cap open ios", | |||
| "build": "cross-env NODE_ENV=production webpack", | |||
| "build:desktop": "npm run build && tauri build", | |||
| "test": "cd .tests && npm run test" | |||
| "build:desktop": "yarn build && TAURI_CONFIG_DIR=$(pwd)/src-tauri tauri build", | |||
There was a problem hiding this comment.
We should use cross-env for Windows support
|
@rihardsgravis good point about Windows support, I actually forgot about that. It looks like the command for getting the current directory isn't the same on Windows: https://stackoverflow.com/questions/921741/windows-equivalent-to-unix-pwd I'm working on a PR for Tauri so that we don't have to specify the full path |
|
See #95 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89