-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Add the MoveAuthenticator generic signature variant and enable AA transactions #9492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vm-lang/aa-auth/8805-beta-feature-branch
Are you sure you want to change the base?
feat: Add the MoveAuthenticator generic signature variant and enable AA transactions #9492
Conversation
Co-authored-by: Valerii Reutov <[email protected]> Co-authored-by: Pavlo Botnar <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
Co-authored-by: Valerii Reutov <[email protected]> Co-authored-by: Pavlo Botnar <[email protected]>
6dccabc to
d19a0d3
Compare
thibault-martinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving dev-tools files
5d6d2da to
9c8a1e7
Compare
kodemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| // Enable Move authentication in devnet | ||
| cfg.feature_flags.move_auth = true; | ||
| // Max auth gas budget is in NANOS and an absolute value 1IOTA | ||
| cfg.max_auth_gas = Some(1_000_000_000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically the parameter used to limit pre-consensus validator's resource usage.
It is currently an arbitrary value and we need some benchmarking in order to set a proper value.
…e-branch' into vm-lang/aa-auth/move-authenticator
Description of change
This part involves the development of a new iota type to represent a new
GenericSignaturevariant, that is theMoveAuthenticatortype, and a execution path to authenticate an Account being the sender of a TX.Internal AA architecture document.
MoveAuthenticatortype has a unique field which iscall_args; this is a vector ofCallArgworking similarly to theProgrammableTransactionBlockinputs.MoveAuthenticatoris used to pass the inputs to the move call indicated by theAuthenticatorInfoV1found attached to the Account object.MoveAuthenticatoris correctly formedMoveAuthenticatorinput objects at a specific versionAuthenticatorInfoV1from the account object dynamic fieldauthenticate()function (that has no effects to store)How the change has been tested
Release Notes