feat(consensus): use iota-http for running the gRPC http server #5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
VorobyevIlya
changed the title
VorobyevIlya
force-pushed
the
consensus/feat/use-sui-http-for-running-the-gRPC-http-server
branch
from
d05a221 to
ccbd495
Compare
VorobyevIlya
changed the title
jkrvivian
approved these changes
Mar 14, 2025
nmrshll
reviewed
Mar 14, 2025
| } | ||
| } | ||
|
|
||
| // TODO: improve iota-http to allow for providing a MakeService so that this can |
There was a problem hiding this comment.
Would it make sense to create an issue for this and reference it here ?
nmrshll
approved these changes
Mar 14, 2025
Thoralf-M
approved these changes
Mar 14, 2025
piotrm50
approved these changes
Mar 17, 2025
VorobyevIlya
force-pushed
the
consensus/feat/impl-ToSocketAddrs-for-Multiaddr
branch
from
368515c to
f2ed986
Compare
VorobyevIlya
force-pushed
the
consensus/feat/use-sui-http-for-running-the-gRPC-http-server
branch
from
35289c8 to
7b7fc99
Compare
VorobyevIlya
force-pushed
the
consensus/feat/impl-ToSocketAddrs-for-Multiaddr
branch
from
f2ed986 to
5abf2c5
Compare
Base automatically changed from
consensus/feat/impl-ToSocketAddrs-for-Multiaddr
to
develop
March 18, 2025 16:46
VorobyevIlya
force-pushed
the
consensus/feat/use-sui-http-for-running-the-gRPC-http-server
branch
from
7b7fc99 to
fce5547
Compare
VorobyevIlya
deleted the
consensus/feat/use-sui-http-for-running-the-gRPC-http-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Porting from upstream MystenLabs/sui@c97668f as part of this PR
Links to any relevant issues
Be sure to reference any related issues by adding
fixes #(issue).Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.