Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): impl to_socket_addrs for multiaddr #5913

Merged

Conversation

VorobyevIlya
Copy link
Contributor

@VorobyevIlya VorobyevIlya commented Mar 13, 2025

Description of change

Porting from upstream MystenLabs/sui@489ab9b as part of this PR

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VorobyevIlya VorobyevIlya self-assigned this Mar 13, 2025
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 1:12pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 1:12pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 1:12pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 1:12pm

@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels Mar 13, 2025
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/impl-ToSocketAddrs-for-Multiaddr branch from f631c74 to 368515c Compare March 13, 2025 16:24
@VorobyevIlya VorobyevIlya changed the title Consensus/feat/impl to_socket_addrs for multiaddr feat(consensus): impl to_socket_addrs for multiaddr Mar 13, 2025
@VorobyevIlya VorobyevIlya marked this pull request as ready for review March 13, 2025 19:20
@VorobyevIlya VorobyevIlya requested a review from a team as a code owner March 13, 2025 19:20
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/add-support-for-gRPC-timeouts branch from b661fe5 to 0577910 Compare March 18, 2025 09:24
@VorobyevIlya VorobyevIlya requested review from a team as code owners March 18, 2025 09:24
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/impl-ToSocketAddrs-for-Multiaddr branch from 368515c to f2ed986 Compare March 18, 2025 09:26
@piotrm50 piotrm50 added this to the v0.11.x - protocol v5 milestone Mar 18, 2025
@VorobyevIlya VorobyevIlya removed the request for review from a team March 18, 2025 09:47
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/add-support-for-gRPC-timeouts branch 2 times, most recently from 654674d to e814bec Compare March 18, 2025 11:51
Base automatically changed from consensus/feat/add-support-for-gRPC-timeouts to develop March 18, 2025 13:08
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/impl-ToSocketAddrs-for-Multiaddr branch from f2ed986 to 5abf2c5 Compare March 18, 2025 13:10
@VorobyevIlya VorobyevIlya merged commit e25912c into develop Mar 18, 2025
35 checks passed
@VorobyevIlya VorobyevIlya deleted the consensus/feat/impl-ToSocketAddrs-for-Multiaddr branch March 18, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants