Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): add vendored version of grpc timeout #5905

Merged

Conversation

VorobyevIlya
Copy link
Contributor

@VorobyevIlya VorobyevIlya commented Mar 13, 2025

Description of change

Porting from upstream MystenLabs/sui@a6298ac as part of this PR

Add a vendored version of the tonic GrpcTimeout layer in order to
support the gRPC deadline/timeout spec when serving gRPC services not
using tonic's transport::server module.

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 9:12am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 9:12am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 9:12am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 9:12am

@VorobyevIlya VorobyevIlya self-assigned this Mar 13, 2025
@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels Mar 13, 2025
@VorobyevIlya VorobyevIlya changed the base branch from develop to consensus/feat/update-telemetry March 13, 2025 16:00
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/update-telemetry branch from 5fffd70 to ce37d3e Compare March 13, 2025 16:03
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/add-vendored-version-of-GrpcTimeout branch from 404b220 to 01979dc Compare March 13, 2025 16:04
@VorobyevIlya VorobyevIlya changed the title Consensus/feat/add vendored version of grpc timeout feat(consensus): add vendored version of grpc timeout Mar 13, 2025
@VorobyevIlya VorobyevIlya marked this pull request as ready for review March 13, 2025 19:19
@VorobyevIlya VorobyevIlya requested review from a team as code owners March 13, 2025 19:19
Base automatically changed from consensus/feat/update-telemetry to develop March 17, 2025 13:03
@piotrm50 piotrm50 requested a review from a team as a code owner March 17, 2025 13:03
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/add-vendored-version-of-GrpcTimeout branch from 01979dc to 1a1b7a2 Compare March 17, 2025 15:01
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/add-vendored-version-of-GrpcTimeout branch from 1a1b7a2 to d869911 Compare March 18, 2025 09:11
@piotrm50 piotrm50 added this to the v0.11.x - protocol v5 milestone Mar 18, 2025
@VorobyevIlya VorobyevIlya merged commit f64a10d into develop Mar 18, 2025
34 checks passed
@VorobyevIlya VorobyevIlya deleted the consensus/feat/add-vendored-version-of-GrpcTimeout branch March 18, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants