Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus): update snapshots and fix failing tests #5833

Conversation

VorobyevIlya
Copy link
Contributor

Description of change

This commit updates snapshots and fixes failing tests in garbage-collection PR #5666.

Links to any relevant issues

fixes #5643

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 5:49pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 5:49pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 5:49pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 5:49pm

@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels Mar 10, 2025
@VorobyevIlya VorobyevIlya changed the title consensus(fix): update snapshots and fix failing tests fix(consensus): update snapshots and fix failing tests Mar 10, 2025
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/garbage-collector branch from b69fa1f to 1e2e852 Compare March 10, 2025 17:05
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/garbage-collector-fix-tests-and-snapshots branch from 9df16e3 to 86d8876 Compare March 10, 2025 17:45
@VorobyevIlya VorobyevIlya force-pushed the consensus/feat/garbage-collector-fix-tests-and-snapshots branch from 86d8876 to 5c77750 Compare March 10, 2025 17:48
@VorobyevIlya VorobyevIlya marked this pull request as ready for review March 10, 2025 18:06
@VorobyevIlya VorobyevIlya requested review from a team as code owners March 10, 2025 18:06
@piotrm50 piotrm50 merged commit 365b94e into consensus/feat/garbage-collector Mar 11, 2025
59 of 61 checks passed
@piotrm50 piotrm50 deleted the consensus/feat/garbage-collector-fix-tests-and-snapshots branch March 11, 2025 09:08
@VorobyevIlya VorobyevIlya restored the consensus/feat/garbage-collector-fix-tests-and-snapshots branch March 14, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants