enhance(test): Add timeout and retry to test to make them more stable #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
muXxer
requested changes
Mar 4, 2025
jkrvivian
force-pushed
the
node/improve-unit-tests
branch
from
cc48452 to
2674f4d
Compare
muXxer
approved these changes
Mar 4, 2025
jkrvivian
force-pushed
the
node/improve-unit-tests
branch
3 times, most recently
from
8fe4a21 to
08ec62b
Compare
|
We're still investigating |
jkrvivian
force-pushed
the
node/improve-unit-tests
branch
from
15449e6 to
4812ebd
Compare
|
Regarding the fix on |
VorobyevIlya
approved these changes
Mar 7, 2025
bingyanglin
approved these changes
Mar 7, 2025
| @@ -982,7 +982,7 @@ impl RandomnessEventLoop { | |||
| continue; // don't send partial sigs to self | |||
| } | |||
| let mut client = RandomnessClient::new(peer.clone()); | |||
| const SEND_PARTIAL_SIGNATURES_TIMEOUT: Duration = Duration::from_secs(10); | |||
| const SEND_PARTIAL_SIGNATURES_TIMEOUT: Duration = Duration::from_secs(30); | |||
There was a problem hiding this comment.
This is the main culprit behind test_byzantine_peer_handling failures. Increasing the timeout seems to help. But it doesn't look like a proper solution.
semenov-vladyslav
force-pushed
the
node/improve-unit-tests
branch
from
e246af5 to
a8c1aee
Compare
semenov-vladyslav
requested review from
msarcev,
alexsporn and
thibault-martinez
as code owners
| // longer to verify invalid signatures and thus needs larger | ||
| // timeouts. | ||
| #[cfg(test)] | ||
| const SEND_PARTIAL_SIGNATURES_TIMEOUT: Duration = Duration::from_secs(500); |
There was a problem hiding this comment.
500 sec seems to work on self-hosted-arm64.
…cutor_crash_recovery
…64, needs investigation" This reverts commit 91be397.
… timeout fix works" test_byzantine_peer_handling succeeded on selfhosted-arm64 with 500 sec timeout: https://github.com/iotaledger/iota/actions/runs/13791724155/job/38573592500#step:9:2993 This reverts commit a4511f2.
muXxer
force-pushed
the
node/improve-unit-tests
branch
from
c34311a to
c4f4882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Rust tests fail during nightly tests, because the tests get slower and thus fail to reach the expected values immediately, this PR adds timeout and retries to fix them.
Links to any relevant issues
Close #5620
Close #5584
Type of change
Change checklist