feat(consensus): resubmit gc-transaction #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
VorobyevIlya
force-pushed
the
consensus/feat/resubmit-gc-transaction
branch
from
1f8d83d to
4ff79fe
Compare
piotrm50
force-pushed
the
consensus/feat/DagState-to-evict-blocks-based-on-GC-round
branch
from
91651f6 to
2418e7f
Compare
polinikita
approved these changes
Mar 5, 2025
piotrm50
force-pushed
the
consensus/feat/resubmit-gc-transaction
branch
from
e76e3a2 to
13b74ae
Compare
piotrm50
force-pushed
the
consensus/feat/DagState-to-evict-blocks-based-on-GC-round
branch
from
50fcc16 to
45d759f
Compare
Base automatically changed from
consensus/feat/DagState-to-evict-blocks-based-on-GC-round
to
consensus/feat/garbage-collector
March 5, 2025 19:31
VorobyevIlya
force-pushed
the
consensus/feat/resubmit-gc-transaction
branch
from
13b74ae to
240967f
Compare
jkrvivian
approved these changes
Mar 7, 2025
Thoralf-M
reviewed
Mar 7, 2025
Thoralf-M
approved these changes
Mar 7, 2025
VorobyevIlya
merged commit 329c17a
into
consensus/feat/garbage-collector
98 of 102 checks passed
VorobyevIlya
added a commit
that referenced
this pull request
Mar 10, 2025
* resubmit gc-transaction * fix formatting * remove dead code * update SubmitToConsensus and ConsensusClient * fix tests amd metrics * fix formatting
VorobyevIlya
added a commit
that referenced
this pull request
Mar 10, 2025
* resubmit gc-transaction * fix formatting * remove dead code * update SubmitToConsensus and ConsensusClient * fix tests amd metrics * fix formatting
piotrm50
pushed a commit
that referenced
this pull request
Mar 14, 2025
* resubmit gc-transaction * fix formatting * remove dead code * update SubmitToConsensus and ConsensusClient * fix tests amd metrics * fix formatting
piotrm50
pushed a commit
that referenced
this pull request
Mar 17, 2025
* resubmit gc-transaction * fix formatting * remove dead code * update SubmitToConsensus and ConsensusClient * fix tests amd metrics * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting upstream change: MystenLabs/sui@ae6275f
Description of change
Copied from upstream:
'Transactions of GC'ed blocks should be retried to remain compliant with
the so far system assumptions. Refactored the consensus side to signal
back the submitter about the status of the block that the submitted
transaction has been included to. Practically two possible outcomes:
as well)
passed gc_round)
also took the opportunity for a small refactoring around the
SubmitToConsensustrait and theConsensusClientas intentionsstarted diverging.'
There is a difference from upstream changes in consensus_tests.rs, since some changes in upstream depend on previous commit f6dd9a8 that we haven't ported yet. So these changes will be ported later.
Links to any relevant issues
Fixes #5643
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.