-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add validator metrics for cpu model and system memory (#4666) #5574
Open
nmrshll
wants to merge
48
commits into
develop
Choose a base branch
from
4666-add-validator-metrics-for-cpu-model-and-system-memory
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(metrics): Add validator metrics for cpu model and system memory (#4666) #5574
nmrshll
wants to merge
48
commits into
develop
from
4666-add-validator-metrics-for-cpu-model-and-system-memory
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ac86a7e
to
2b64553
Compare
28aa366
to
98362c0
Compare
alexsporn
reviewed
Mar 10, 2025
alexsporn
reviewed
Mar 10, 2025
alexsporn
reviewed
Mar 10, 2025
…-metrics-for-cpu-model-and-system-memory
…-metrics-for-cpu-model-and-system-memory
I pushed some fixes. Now the metrics also work when run via Please also implement the following changes:
|
…-metrics-for-cpu-model-and-system-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Introduces enhancements to the validator metrics by adding support for getting validator hardware specs, like CPU model/cores, system memory, disk space. This data is sent to iota-proxy (for us to monitor the state of the network through telemetry).
Also fixes private network setup scripts/configs, which didn't seem to work with the exact commands given in the different READMEs (I encountered the same problems as described in #5204, had to fix them to test this PR with docker)
Added example grafana dashboard items:
Links to any relevant issues
Fixes #4666.
Platform support:
Type of change
How the change has been tested
The changes have been tested in a local environment to ensure that the new metrics are being collected correctly and that the private network setup works seamlessly with Grafana. Further testing will be conducted based on feedback received.
Change checklist