Fix #22491: bug: tap click cancels gesture when used on button#30966
Open
danielalanbates wants to merge 1 commit intoionic-team:mainfrom
Open
Fix #22491: bug: tap click cancels gesture when used on button#30966danielalanbates wants to merge 1 commit intoionic-team:mainfrom
danielalanbates wants to merge 1 commit intoionic-team:mainfrom
Conversation
…ture is captured When a gesture is captured via GestureController, the ionGestureCaptured event previously caused tap-click to unconditionally cancel the active ripple effect. This broke the ripple effect on ion-button and ion-fab-button when a custom gesture (e.g. long-press) was applied to those elements. The fix passes the gesture element through the ionGestureCaptured event detail and skips cancelActive() in tap-click when the element is or descends from an ion-activatable element. Fixes ionic-team#22491
|
@renoschubert is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22491
Summary
This PR fixes: bug: tap click cancels gesture when used on button
Changes
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license (contributor license agreement).