-
Notifications
You must be signed in to change notification settings - Fork 13.4k
chore(angular): upgrade test apps to latest #30517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
da108e7
chore(angular): upgrade base tsconfig to latest
thetaPC 4f6ccc0
chore(angular): move gitkeep to base
thetaPC 92a13ed
chore(angular): update base tsconfig.spec
thetaPC 97effb5
chore(angular): update base tsconfig.server
thetaPC 0f4ba04
chore(angular): update base tsconfig
thetaPC 8a95b19
chore(angular): update base tsconfig.app
thetaPC 867dffc
chore(angular): remove extra server files
thetaPC 3cd5e13
chore(angular): update angular.json
thetaPC 9fe7c7b
chore(angular): update main.server
thetaPC 2061a7b
chore(angular): update app-routing.module
thetaPC 4039ed1
chore(angular): update version-test-routing.module
thetaPC 1167c97
chore(angular): add modal-nav-params to base
thetaPC 1d67561
docs(angular): add reason for syncing
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"angularCompilerOptions": { | ||
"fullTemplateTypeCheck": true, | ||
"strictMetadataEmit" : true | ||
}, | ||
"extends": "../tsconfig.json", | ||
"include": [ | ||
"src/**spec.ts", | ||
"../cypress/support/index.d.ts" | ||
], | ||
"compilerOptions": { | ||
"outDir": "../out-tsc/app", | ||
"module": "commonjs", | ||
"target": "es5", | ||
"types": [ | ||
"cypress", | ||
"node" | ||
] | ||
} | ||
} |
10 changes: 0 additions & 10 deletions
10
packages/angular/test/apps/ng16/src/app/app-routing.module.ts
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
packages/angular/test/apps/ng16/src/app/lazy/version-test/version-test-routing.module.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
"compilerOptions": { | ||
"outDir": "./out-tsc/app" | ||
}, | ||
"files": [ | ||
"src/main.ts", | ||
"src/polyfills.ts", | ||
"src/zone-flags.ts" | ||
], | ||
"include": ["src/**/*.d.ts"] | ||
} |
14 changes: 6 additions & 8 deletions
14
...gular/test/apps/ng20/tsconfig.server.json → ...gular/test/apps/ng16/tsconfig.server.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"angularCompilerOptions": { | ||
"fullTemplateTypeCheck": true, | ||
"strictMetadataEmit" : true | ||
}, | ||
"extends": "../tsconfig.json", | ||
"include": [ | ||
"src/**spec.ts", | ||
"../cypress/support/index.d.ts" | ||
], | ||
"compilerOptions": { | ||
"outDir": "../out-tsc/app", | ||
"module": "commonjs", | ||
"target": "es5", | ||
"types": [ | ||
"cypress", | ||
"node" | ||
] | ||
} | ||
} |
10 changes: 0 additions & 10 deletions
10
packages/angular/test/apps/ng17/src/app/app-routing.module.ts
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
packages/angular/test/apps/ng17/src/app/lazy/version-test/version-test-routing.module.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
"compilerOptions": { | ||
"outDir": "./out-tsc/app" | ||
}, | ||
"files": [ | ||
"src/main.ts", | ||
"src/polyfills.ts", | ||
"src/zone-flags.ts" | ||
], | ||
"include": ["src/**/*.d.ts"] | ||
} |
14 changes: 6 additions & 8 deletions
14
...gular/test/apps/ng19/tsconfig.server.json → ...gular/test/apps/ng17/tsconfig.server.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"angularCompilerOptions": { | ||
"fullTemplateTypeCheck": true, | ||
"strictMetadataEmit" : true | ||
}, | ||
"extends": "../tsconfig.json", | ||
"include": [ | ||
"src/**spec.ts", | ||
"../cypress/support/index.d.ts" | ||
], | ||
"compilerOptions": { | ||
"outDir": "../out-tsc/app", | ||
"module": "commonjs", | ||
"target": "es5", | ||
"types": [ | ||
"cypress", | ||
"node" | ||
] | ||
} | ||
} |
10 changes: 0 additions & 10 deletions
10
packages/angular/test/apps/ng18/src/app/app-routing.module.ts
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
packages/angular/test/apps/ng18/src/app/lazy/version-test/version-test-routing.module.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import { enableProdMode } from '@angular/core'; | ||
|
||
import { environment } from './environments/environment'; | ||
|
||
if (environment.production) { | ||
enableProdMode(); | ||
} | ||
|
||
export { AppServerModule } from './app/app.server.module'; | ||
export { renderModule, renderModuleFactory } from '@angular/platform-server'; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was considered a rename when I manually deleted the file from
ng19
and added a new file withinng16
. The same applies for the other renames.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git doesn't have a way to identify when a file was deleted or renamed, so if a file is removed and another one is added and they're similar enough it just considers it a rename. If a file just disappears then it considers it deleted. Sometimes it has false positives like this haha