-
Notifications
You must be signed in to change notification settings - Fork 44
chore: update npm packages #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import '@capacitor/google-maps'; | ||
|
|
||
| declare global { | ||
| namespace JSX { | ||
| interface IntrinsicElements { | ||
| 'capacitor-google-map': React.DetailedHTMLProps<React.HTMLAttributes<HTMLElement>, HTMLElement>; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export {}; | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,11 @@ | ||
| /// <reference types="react-scripts" /> | ||
|
|
||
| declare global { | ||
| namespace JSX { | ||
| interface IntrinsicElements { | ||
| 'capacitor-google-map': React.DetailedHTMLProps<React.HTMLAttributes<HTMLElement>, HTMLElement>; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export {}; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ | |
| "jsx": "react-jsx" | ||
| }, | ||
| "include": [ | ||
| "src" | ||
| "src", | ||
| "src/**/*.d.ts" | ||
| ] | ||
| } | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1068,30 +1068,32 @@ A marker is an icon placed at a particular point on the map's surface. | |
|
|
||
| #### Point | ||
|
|
||
| | Prop | Type | | ||
| | ------- | ------------------- | | ||
| | **`x`** | <code>number</code> | | ||
| | **`y`** | <code>number</code> | | ||
| <a href="#point">Point</a> geometry object. | ||
| https://tools.ietf.org/html/rfc7946#section-3.1.2 | ||
|
|
||
| | Prop | Type | Description | | ||
| | ----------------- | --------------------------------------------- | ------------------------------------- | | ||
| | **`type`** | <code>'<a href="#point">Point</a>'</code> | Specifies the type of GeoJSON object. | | ||
| | **`coordinates`** | <code><a href="#position">Position</a></code> | | | ||
|
|
||
|
|
||
| #### Position | ||
|
|
||
| | Prop | Type | Description | | ||
| | ------------ | ------------------- | ----------- | | ||
| | **`line`** | <code>number</code> | >= 1 | | ||
| | **`column`** | <code>number</code> | >= 0 | | ||
|
Comment on lines
+1071
to
+1085
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, I think this is something that has resurfaced, that was originally fixed by #89. Perhaps the script I added no longer works with these updated dependencies? |
||
|
|
||
|
|
||
| #### Polygon | ||
|
|
||
| For web, all the javascript <a href="#polygon">Polygon</a> options are available as | ||
| Polygon extends google.maps.PolygonOptions. | ||
| For iOS and Android only the config options declared on <a href="#polygon">Polygon</a> are available. | ||
| <a href="#polygon">Polygon</a> geometry object. | ||
| https://tools.ietf.org/html/rfc7946#section-3.1.6 | ||
|
|
||
| | Prop | Type | Description | | ||
| | ------------------- | ----------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | **`paths`** | <code>any[] \| MVCArray<any></code> | The ordered sequence of coordinates that designates a closed loop. Unlike polylines, a polygon may consist of one or more paths. As a result, the paths property may specify one or more arrays of <code><a href="#latlng">LatLng</a></code> coordinates. Paths are closed automatically; do not repeat the first vertex of the path as the last vertex. Simple polygons may be defined using a single array of <code><a href="#latlng">LatLng</a></code>s. More complex polygons may specify an array of arrays. Any simple arrays are converted into <code><a href="#MVCArray">MVCArray</a></code>s. Inserting or removing <code><a href="#latlng">LatLng</a></code>s from the <code>MVCArray</code> will automatically update the polygon on the map. | | ||
| | **`strokeColor`** | <code>string</code> | The stroke color. All CSS3 colors are supported except for extended named colors. | | ||
| | **`strokeOpacity`** | <code>number</code> | The stroke opacity between 0.0 and 1.0 | | ||
| | **`strokeWeight`** | <code>number</code> | The stroke width in pixels. | | ||
| | **`fillColor`** | <code>string</code> | The fill color. All CSS3 colors are supported except for extended named colors. | | ||
| | **`fillOpacity`** | <code>number</code> | The fill opacity between 0.0 and 1.0 | | ||
| | **`geodesic`** | <code>boolean</code> | When <code>true</code>, edges of the polygon are interpreted as geodesic and will follow the curvature of the Earth. When <code>false</code>, edges of the polygon are rendered as straight lines in screen space. Note that the shape of a geodesic polygon may appear to change when dragged, as the dimensions are maintained relative to the surface of the earth. | | ||
| | **`clickable`** | <code>boolean</code> | Indicates whether this <code><a href="#polygon">Polygon</a></code> handles mouse events. | | ||
| | **`title`** | <code>string</code> | Title, a short description of the overlay. Some overlays, such as markers, will display the title on the map. The title is also the default accessibility text. Only available on iOS. | | ||
| | **`tag`** | <code>string</code> | | | ||
| | Prop | Type | Description | | ||
| | ----------------- | --------------------------------------------- | ------------------------------------- | | ||
| | **`type`** | <code>'<a href="#polygon">Polygon</a>'</code> | Specifies the type of GeoJSON object. | | ||
| | **`coordinates`** | <code>Position[][]</code> | | | ||
|
|
||
|
|
||
| #### Circle | ||
|
|
@@ -1267,6 +1269,29 @@ The callback function to be called when map events are emitted. | |
| <code>(data: T): void</code> | ||
|
|
||
|
|
||
| #### Position | ||
|
|
||
| A <a href="#position">Position</a> is an array of coordinates. | ||
| https://tools.ietf.org/html/rfc7946#section-3.1.1 | ||
| Array should contain between two and three elements. | ||
| The previous GeoJSON specification allowed more elements (e.g., which could be used to represent M values), | ||
| but the current specification only allows X, Y, and (optionally) Z to be defined. | ||
|
|
||
| Note: the type will not be narrowed down to `[number, number] | [number, number, number]` due to | ||
| marginal benefits and the large impact of breaking change. | ||
|
|
||
| See previous discussions on the type narrowing: | ||
| - {@link https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21590|Nov 2017} | ||
| - {@link https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/67773|Dec 2023} | ||
| - {@link https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/71441| Dec 2024} | ||
|
|
||
| One can use a | ||
| {@link https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates|user-defined type guard that returns a type predicate} | ||
| to determine if a position is a 2D or 3D position. | ||
|
|
||
| <code>number[]</code> | ||
|
|
||
|
|
||
| #### Marker | ||
|
|
||
| Supports markers of either either "legacy" or "advanced" types. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this change was necessary because of the dependency updates in the app, not the dependency updates in the plugin?
In other words if they update the plugin to the future Cap 8 compatible version without touching anything else, they won't need to add this right?