Improve MaskOutput dimension consistency #7591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hannel dimension of size 1. This is the convention used by other nodes that produce a MaskOutput.
RyanJDick
requested review from
blessedcoolant,
psychedelicious,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Jan 24, 2025
|
Typegen failing check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with mask dimension consistency. Prior to this change, the following workflow would fail with
tuple out of rangeerror:Before this PR
Dimension compatibility for invocations that take a mask input:
ApplyMaskTensorToImageInvocation: 2 or 3MaskTensorToImageInvocation: 2 or 3InvertTensorMaskInvocation: 3Mask dimension for invocations that produce a MaskOutput:
RectangleMaskInvocation: 3AlphaMaskToTensorInvocation: 3InvertTensorMaskInvocation: 3ImageMaskToTensorInvocation: 3SegmentAnythingInvocation: 2After this PR (changes in bold)
Dimension compatibility for invocations that take a mask input:
ApplyMaskTensorToImageInvocation: 2 or 3MaskTensorToImageInvocation: 2 or 3InvertTensorMaskInvocation: 2 or 3 <----------------Mask dimension for invocations that produce a MaskOutput:
RectangleMaskInvocation: 3AlphaMaskToTensorInvocation: 3InvertTensorMaskInvocation: 3ImageMaskToTensorInvocation: 3SegmentAnythingInvocation: 3 <-------------------QA Instructions
I tested the workflow in the PR description and this workflow:
Merge Plan
No special instructions.
Checklist
What's Newcopy (if doing a release after this PR)