-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: string batch generators #7572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same UI & better perf thanks to a different structure.
- Split into two (random and combinatorial) - lots of fiddly logic to do both in one generator. - Update to support seeds for random.
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
January 18, 2025 23:58
github-actions
bot
added
api
python
PRs that change python files
invocations
PRs that change invocations
frontend
PRs that change frontend files
labels
Jan 18, 2025
Demo of the string generators and load from file functionality. All generators that take a string input support load from file and have the same parsing (shown with the float generator). Screen.Recording.2025-01-20.at.8.37.54.am.mov |
hipsterusername
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
frontend
PRs that change frontend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add string batch generators:
The dynamic prompts generators are split like this because
Support loading from file for all string input generators. The files are loaded into memory in the frontend, they are never uploaded to the server. Max size of 128KB bc we don't want to load so much data into the node. This might be way too big but it shouldn't break anything, might just be a bit laggy if a user loads such a huge list of strings.
Support for special characters like
\n
to split string inputs on newlines.Related Issues / Discussions
QA Instructions
Try it out!
Merge Plan
n/a
Checklist