refactor(ui): batch generator nodes #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
1 task
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
hipsterusername
approved these changes
Jan 17, 2025
psychedelicious
force-pushed
the
psyche/feat/zipped-batches
branch
from
74a4197 to
81e21cc
Compare
- Add `batch` property to field type object to differentiate between executable nodes and batch/generator nodes. - Support for float generators
…dist, uniform rand dist)
psychedelicious
force-pushed
the
psyche/feat/generator-nodes
branch
from
438820b to
bbac75a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Another approach to generators. This one makes them into nodes, and is a far less invasive change than the approach in #7559. In hindsight, this is the obvious way to handle generators. Will fill in PR description tomorrow.
Related Issues / Discussions
Supersedes #7559
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)