-
Notifications
You must be signed in to change notification settings - Fork 2.3k
refactor(firestore): improve firestore types and add test #8698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d76f16c to
1dc6da7
Compare
|
Hey there, any updates on this? Just got a runtime error as |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Hey @mikehardy @ycmjason , any updates on this one? Let me know if I can help somehow. Thank you |
Description
#8611 flaged that many types are currently broken.
This PR fixes most of the type issues by removing
<AppModelType, DbModelType>and replaced with<T extends DocumentData>.Also added
tsdto make sure our.d.tsare legit. Fixed many issues thanks to it!Related issues
#8611
Release Summary
Fix types for firestore
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Added
tsdto add some type testings to our apis.Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter