feat: Refactor Response class and add new initialization methods #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default response status and status text in the `Response` constructors - Add `Response.jsify` method for initializing `Response` with a JS object as body - Separate `Response.json` method from `Response.jsify` for initializing `Response` with a JSON-encodable object as body - Add documentation for main the constructors of `Response`
Salakar
approved these changes
May 2, 2023
Member
|
@gaetschwartz thanks for this - what's the use case for the |
Contributor
Author
|
Well, as |
rrousselGit
reviewed
Jun 27, 2023
Collaborator
|
I'm not really familiar with the project, but it looks alright at a quick glance. I'd still consider this a breaking change (since the "json" constructor changes). |
rrousselGit
reviewed
Jun 27, 2023
Co-authored-by: Remi Rousselet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ResponseconstructorsResponse.jsifymethod for initializingResponsewith a JS object as bodyResponse.jsonmethod fromResponse.jsifyfor initializingResponsewith a JSON-encodable object as bodyResponseMotivation
jsifyis subject to minification and has somewhat bad performance. When usingdart compilewith minification enabled, the response json gets minified (after a certain depth AFAIK). It should not be the case. The newResponse.jsonbehaves simlarly from the previous implementation except that it doesn't minify as it usesjson.encode. Renamed the previous implementation toResponse.jsifyas it could still be useful for some cases.