Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1-1 #16

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

V1-1 #16

wants to merge 18 commits into from

Conversation

JeGoi
Copy link
Contributor

@JeGoi JeGoi commented Oct 1, 2021

Add debug mode
Clean functions
Clean exit
Clean few other stuff
Remove fatal
Move print stdout to debug
Etc.

@JeGoi JeGoi requested review from julsemaan and nqb October 1, 2021 20:41
badCertificatePassword = true
mw.Close()
case int(ERROR_INVALID_DATA):
walk.MsgBox(windowMsgBox, T("errorWindowTitle"), T("invalidCertificate"), walk.MsgBoxOK)
os.Remove(userCertDecode)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this massive copy/paste needs to be removed but I don't see it in the defer so that it still happens when this is done

This would mean the files are left there after it exits unless I'm missing where this has been added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files are now removed on exit.
In utils.go, func cleanTmpFiles

Copy link

@nqb nqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find addNewLinesToDebug function name not really appropriate.
If I'm not wrong, purpose of this function is:

  • in debug, to print text in a specific manner (certainly through a specific window)
    or
  • to print text

certificate.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
parse.go Show resolved Hide resolved
utils.go Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
@julsemaan
Copy link
Collaborator

Please make sure you run all the files through go fmt if that's not done already

JeGoi added 5 commits October 5, 2021 12:50
Change Variables to Structures shared across functions
Add catch when return something different than 200
Instanciate WinAgent* Objects
@extrafu
Copy link
Member

extrafu commented Oct 22, 2021

This still needs to be merged prior the release.

@julsemaan
Copy link
Collaborator

The agent in this PR is unable to install an EAP-TLS profile since its unable to install the CA

Tested stable agent and this agent with the same configuration, stable works, this doesn't

Will wait for @JeGoi to look into it, we should shovel this to 11.2 if its not a quick fix

@julsemaan
Copy link
Collaborator

I was able to test EAP-PEAP successfully but EAP-TLS has failed to install the CA:

============== PacketFence Provisioning Agent ==============
User's locale uint16 is: 3084
Language file successfully created.
Program will be translated in french.
The current build windows is after 2004 version: 19044
Welcome to PF debug
PNG file pf_bg.png successfully created at C:\Users\prime\Ap
pData\Local\Temp\pf_bg.png
Been able to attach background image.
Extract Wireless configuration profile: 13
L'Autorité de Certification n'a pas pu être installée sur vo
tre machine, contactez votre support local. exit status 0x80
070003
Erreur lors de l'ouverture du fichier d'Autorité de Certific
ation, contactez votre support local. open : Le fichier spéc
ifié est introuvable.
Unable to get CA fingerprint. open : Le fichier spécifié est
 introuvable.
executetemplateSuccess
EAP Type is: 13
Le fichier de profil a été créé avec succès.
Success adding profile The wireless profile was successfully
 added to the machine.
Please select your newly added profi
le Boulette-Secure in the WiFi networks. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants