-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1-1 #16
base: master
Are you sure you want to change the base?
Conversation
badCertificatePassword = true | ||
mw.Close() | ||
case int(ERROR_INVALID_DATA): | ||
walk.MsgBox(windowMsgBox, T("errorWindowTitle"), T("invalidCertificate"), walk.MsgBoxOK) | ||
os.Remove(userCertDecode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this massive copy/paste needs to be removed but I don't see it in the defer so that it still happens when this is done
This would mean the files are left there after it exits unless I'm missing where this has been added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files are now removed on exit.
In utils.go, func cleanTmpFiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find addNewLinesToDebug
function name not really appropriate.
If I'm not wrong, purpose of this function is:
- in debug, to print text in a specific manner (certainly through a specific window)
or - to print text
Fix command line Fix mix template vs profile Remove extra file creation Workflow more accurate
Please make sure you run all the files through |
Change Variables to Structures shared across functions Add catch when return something different than 200
Instanciate WinAgent* Objects
This still needs to be merged prior the release. |
The agent in this PR is unable to install an EAP-TLS profile since its unable to install the CA Tested stable agent and this agent with the same configuration, stable works, this doesn't Will wait for @JeGoi to look into it, we should shovel this to 11.2 if its not a quick fix |
I was able to test EAP-PEAP successfully but EAP-TLS has failed to install the CA:
|
Add debug mode
Clean functions
Clean exit
Clean few other stuff
Remove fatal
Move print stdout to debug
Etc.