-
Notifications
You must be signed in to change notification settings - Fork 541
Feat/add mcp server capacities for tasks and audits #2919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jledoze
wants to merge
11
commits into
intuitem:main
Choose a base branch
from
jledoze:feat/add_mcp_server_capacities_for_tasks_and_audits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a958b55
Add tasks creation, update and deletion features
jledoze 8a29c92
Fix typo detected by CodeRabbit
jledoze c7527a7
Fix resolver issue
jledoze 6fbe36a
Fix applied_controls type description
jledoze e6952ab
Fix cost type
jledoze cf04a31
Fix code linting issue
jledoze 8cb3e54
Delete cli/.mcp.env
jledoze 5f7f3fd
Remove env file from git to avoid secrets leak
jledoze b4023b0
Modify readme and add example mcp environment file to avoid secret le…
jledoze ba7f4de
Applying CodeRabbit suggestion
jledoze 0d3df04
Resolve applied_controls before sending anything
jledoze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve
get_applied_controlsUUID and cost display defaults.The new columns are useful, but two small details could improve correctness/readability:
uuid = item.get("id")will renderNoneifidis ever missing; other tables typically default to"N/A".cost = item.get("cost", 0)will show0when the cost field is absent, which can be misleading given thatcostis modeled as a complex JSON object elsewhere.Consider:
This keeps the table consistent with other read tools and avoids treating missing structured
costas a numeric zero.Also applies to: 115-128