-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Server Manager's View Container #1270
Use Server Manager's View Container #1270
Conversation
Today I have installed this dev VSIX and the Server Manager one (intersystems-community/intersystems-servermanager#216), so they'll start getting some usage here. Perhaps we should release this as 2.12.0 in recognition of its new dependency on Server Manager, which we are also intending to increment the minor version of (to 3.6.0) |
Thanks for trying this John! I didn't bump the minor version here because I did it in #1269 and I figured that both of these PRs would be in a hypothetical 2.12.0. |
@isc-bsaviano with the merged views we lose the "ObjectScript" heading on the container, so I suggest changing the "Explorer" panel to "ObjectScript Explorer". |
@isc-rsingh I don't mind calling it the "InterSystems Explorer" (the view container's name plus the view's name), which is what will be shown if the view is moved from the default view container. I've already alerted Shawn that the docs will need some changes to accommodate this pull request so I don't see this minor name change as a problem. We could also keep referring to it as the "ObjectScript Explorer", but I don't think that long name needs to be in the UI. |
The goal of this PR and its dependency is to group all three InterSystems views (Explorer, Projects, Servers) under a single "InterSystems" view container. The end result for the user will be a single view container using the ISC logo containing all three views, instead of the Servers view being under the "InterSystems Tools" view container (toolbox.
Requires intersystems-community/intersystems-servermanager#216