Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Server Manager's View Container #1270

Merged

Conversation

isc-bsaviano
Copy link
Contributor

@isc-bsaviano isc-bsaviano commented Nov 3, 2023

The goal of this PR and its dependency is to group all three InterSystems views (Explorer, Projects, Servers) under a single "InterSystems" view container. The end result for the user will be a single view container using the ISC logo containing all three views, instead of the Servers view being under the "InterSystems Tools" view container (toolbox.

Requires intersystems-community/intersystems-servermanager#216

@gjsjohnmurray
Copy link
Contributor

Today I have installed this dev VSIX and the Server Manager one (intersystems-community/intersystems-servermanager#216), so they'll start getting some usage here.

Perhaps we should release this as 2.12.0 in recognition of its new dependency on Server Manager, which we are also intending to increment the minor version of (to 3.6.0)

@isc-bsaviano
Copy link
Contributor Author

Thanks for trying this John! I didn't bump the minor version here because I did it in #1269 and I figured that both of these PRs would be in a hypothetical 2.12.0.

@isc-bsaviano isc-bsaviano marked this pull request as ready for review January 4, 2024 14:04
@isc-rsingh
Copy link
Member

@isc-bsaviano with the merged views we lose the "ObjectScript" heading on the container, so I suggest changing the "Explorer" panel to "ObjectScript Explorer".

image

@isc-bsaviano
Copy link
Contributor Author

isc-bsaviano commented Jan 4, 2024

@isc-rsingh I don't mind calling it the "InterSystems Explorer" (the view container's name plus the view's name), which is what will be shown if the view is moved from the default view container. I've already alerted Shawn that the docs will need some changes to accommodate this pull request so I don't see this minor name change as a problem. We could also keep referring to it as the "ObjectScript Explorer", but I don't think that long name needs to be in the UI.

isc-rsingh
isc-rsingh previously approved these changes Jan 4, 2024
@isc-bsaviano isc-bsaviano merged commit 0845858 into intersystems-community:master Jan 5, 2024
7 checks passed
@isc-bsaviano isc-bsaviano deleted the view-update branch January 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants