Skip to content

Commit

Permalink
Merge pull request #213 from gjsjohnmurray/fix-212
Browse files Browse the repository at this point in the history
Add 'Remove from Recent' to context menu of Recent entry
  • Loading branch information
gjsjohnmurray authored Aug 18, 2023
2 parents aa69807 + 2c275b9 commit 18b320a
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
13 changes: 13 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@
"title": "Remove from Favorites",
"icon": "$(star-empty)"
},
{
"command": "intersystems-community.servermanager.removeFromRecent",
"title": "Remove from Recent"
},
{
"command": "intersystems-community.servermanager.openPortalExternal",
"title": "Open Management Portal in External Browser",
Expand Down Expand Up @@ -411,6 +415,10 @@
"command": "intersystems-community.servermanager.removeFromStarred",
"when": "false"
},
{
"command": "intersystems-community.servermanager.removeFromRecent",
"when": "false"
},
{
"command": "intersystems-community.servermanager.openPortalExternal",
"when": "false"
Expand Down Expand Up @@ -592,6 +600,11 @@
"command": "intersystems-community.servermanager.editSettings",
"when": "view == intersystems-community_servermanager && viewItem =~ /\\.server\\./",
"group": "1_edit@20"
},
{
"command": "intersystems-community.servermanager.removeFromRecent",
"when": "view == intersystems-community_servermanager && viewItem =~ /^recent.server./",
"group": "2_manage@10"
}
]
}
Expand Down
7 changes: 7 additions & 0 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ export function activate(context: vscode.ExtensionContext) {
}
}),
);
context.subscriptions.push(
vscode.commands.registerCommand(`${extensionId}.removeFromRecent`, async (server?: ServerTreeItem) => {
if (server?.name) {
await view.removeFromRecents(server.name);
}
}),
);
context.subscriptions.push(
vscode.commands.registerCommand(`${extensionId}.openPortalExternal`, (server?: ServerTreeItem) => {
if (server?.contextValue?.match(/\.server\./) && server.name) {
Expand Down
6 changes: 6 additions & 0 deletions src/ui/serverManagerView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ export class ServerManagerView {
}
}

public async removeFromRecents(name: string) {
recentsArray = recentsArray.filter((n) => n !== name);
this.refreshTree();
await this._globalState.update(StorageIds.recents, recentsArray);
}

public async addToFavorites(name: string) {
if (!favoritesMap.has(name)) {
favoritesMap.set(name, null);
Expand Down

0 comments on commit 18b320a

Please sign in to comment.