Skip to content

[PB-3723]:fix/make dropdown, list and breadcrumbs responsive #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jona-Internxt merged 1 commit into from
Feb 3, 2025
Merged

[PB-3723]:fix/make dropdown, list and breadcrumbs responsive #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@internxt/ui",
"version": "0.0.14",
"version": "0.0.15",
"description": "Library of Internxt components",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions src/components/breadcrumbs/__test__/__snapshots__/Breadcrumbs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`Breadcrumbs Component > should match snapshot 1`] = `
</svg>
</div>
<div
class="relative outline-none"
class="relative outline-none min-w-breadcrumb"
>
<button
aria-expanded="false"
Expand Down Expand Up @@ -202,7 +202,7 @@ exports[`Breadcrumbs Component > should match snapshot 1`] = `
</svg>
</div>
<div
class="relative outline-none"
class="relative outline-none min-w-breadcrumb"
>
<button
aria-expanded="false"
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const Dropdown = <T,>({
const { px, py } = extractPaddingValues(classMenuItems);

return (
<div className="relative outline-none" ref={containerRef}>
<div className="relative outline-none min-w-breadcrumb" ref={containerRef}>
<button
className={`cursor-pointer outline-none ${classButton}`}
onClick={toggleMenu}
Expand Down
2 changes: 1 addition & 1 deletion src/components/dropdown/__test__/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`Dropdown component > should match snapshot 1`] = `
<div>
<div
class="relative outline-none"
class="relative outline-none min-w-breadcrumb"
>
<button
aria-expanded="false"
Expand Down
4 changes: 2 additions & 2 deletions src/components/list/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ const List = <T extends { id: number }, F extends keyof T>({
return (
<div
id="generic-list-component"
className={`relative flex h-full flex-col overflow-x-hidden overflow-y-hidden ${className}`}
className={`relative flex h-full flex-col overflow-x-auto overflow-y-hidden ${className}`}
ref={containerRef}
>
{!isEmptyState ? (
Expand All @@ -313,7 +313,7 @@ const List = <T extends { id: number }, F extends keyof T>({
) : null}

{/* BODY */}
<div id="scrollableList" className="flex h-full flex-col overflow-x-auto overflow-y-auto">
<div id="scrollableList" className="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto">
{isEmptyState ? (
emptyState
) : items.length > 0 && !forceLoading ? (
Expand Down
2 changes: 1 addition & 1 deletion src/components/list/ListHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ListHeader = <T, F extends keyof T>({
onClose,
}: ListHeaderProps<T, F>) => {
return (
<div onClick={onClose} onContextMenu={onClose} className="flex h-12 shrink-0 flex-row px-5">
<div onClick={onClose} onContextMenu={onClose} className="flex min-w-max h-12 shrink-0 flex-row px-5">
{/* COLUMN */}
<div className="flex h-full min-w-full flex-row items-center border-b border-gray-10">
{/* SELECTION CHECKBOX */}
Expand Down
12 changes: 6 additions & 6 deletions src/components/list/__test__/__snapshots__/List.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ exports[`List component > should match snapshot 1`] = `
"baseElement": <body>
<div>
<div
class="relative flex h-full flex-col overflow-x-hidden overflow-y-hidden undefined"
class="relative flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
id="generic-list-component"
>
<div
class="flex h-12 shrink-0 flex-row px-5"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
Expand Down Expand Up @@ -76,7 +76,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
</div>
<div
class="flex h-full flex-col overflow-x-auto overflow-y-auto"
class="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto"
id="scrollableList"
>
<div>
Expand Down Expand Up @@ -200,11 +200,11 @@ exports[`List component > should match snapshot 1`] = `
</body>,
"container": <div>
<div
class="relative flex h-full flex-col overflow-x-hidden overflow-y-hidden undefined"
class="relative flex h-full flex-col overflow-x-auto overflow-y-hidden undefined"
id="generic-list-component"
>
<div
class="flex h-12 shrink-0 flex-row px-5"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
Expand Down Expand Up @@ -270,7 +270,7 @@ exports[`List component > should match snapshot 1`] = `
</div>
</div>
<div
class="flex h-full flex-col overflow-x-auto overflow-y-auto"
class="flex h-full flex-col min-w-max overflow-x-hidden overflow-y-auto"
id="scrollableList"
>
<div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/list/__test__/__snapshots__/ListHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`ListHeader > should match snapshot 1`] = `
"baseElement": <body>
<div>
<div
class="flex h-12 shrink-0 flex-row px-5"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
Expand Down Expand Up @@ -56,7 +56,7 @@ exports[`ListHeader > should match snapshot 1`] = `
</body>,
"container": <div>
<div
class="flex h-12 shrink-0 flex-row px-5"
class="flex min-w-max h-12 shrink-0 flex-row px-5"
>
<div
class="flex h-full min-w-full flex-row items-center border-b border-gray-10"
Expand Down