Skip to content

Conversation

@evillalba94
Copy link
Contributor

@evillalba94 evillalba94 commented Dec 24, 2024

Do not merge until WIP is merged

Ticket

Updates

  • Add new endpoint call to get ancestors by itemType and Uuid

PR related

}

/**
* Gets the ancestors of a given UUID and type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Gets the ancestors of an item with the given UUID and type

@CandelR CandelR self-requested a review December 26, 2024 06:41
Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the package version

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.86%. Comparing base (a6c3411) to head (243fc25).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
src/drive/storage/index.ts 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   63.16%   62.86%   -0.30%     
==========================================
  Files          41       42       +1     
  Lines        1474     1508      +34     
  Branches      229      239      +10     
==========================================
+ Hits          931      948      +17     
- Misses        476      487      +11     
- Partials       67       73       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CandelR CandelR self-requested a review December 30, 2024 07:32
Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that version 1.9.0 of the sdk has no breaking changes? I just saw that the latest released in npm is 1.8.1.

@CandelR
Copy link
Contributor

CandelR commented Jan 8, 2025

@jvedrson please, review this

Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov report shows the lines that are not covered, could you check it and add the tests to increase the coverage? 🙏

@CandelR CandelR merged commit c6a42ff into master Jan 30, 2025
2 checks passed
@CandelR CandelR deleted the feat/pb-2424-shared-items-details branch January 30, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants