-
Notifications
You must be signed in to change notification settings - Fork 3
Add missing kyber keys #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
efc5ae4
add missing kyber keys
TamaraFinogina c05b090
increase version
TamaraFinogina d9a7812
Merge remote-tracking branch 'origin/master' into feat/add_kyber_to_s…
TamaraFinogina e8ea9ed
set version to 1.9.2
TamaraFinogina 56b2044
add kyber to password change
TamaraFinogina 8feb61e
add deprecated comment
TamaraFinogina 18887f9
make kyber key an optiona field
TamaraFinogina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "name": "@internxt/sdk", | ||
| "author": "Internxt <[email protected]>", | ||
| "version": "1.9.0", | ||
| "version": "1.9.1", | ||
| "description": "An sdk for interacting with Internxt's services", | ||
| "repository": { | ||
| "type": "git", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,6 +100,7 @@ describe('# users service tests', () => { | |
| const email = '[email protected]'; | ||
| const callStub = sinon.stub(httpClient, 'post').resolves({ | ||
| publicKey: 'publicKey', | ||
| publicKyberKey: 'publicKeyberKey', | ||
| user: { uuid: 'exampleUuid', email }, | ||
| }); | ||
|
|
||
|
|
@@ -110,6 +111,7 @@ describe('# users service tests', () => { | |
| expect(callStub.firstCall.args).toEqual(['/users/pre-create', { email }, headers]); | ||
| expect(body).toEqual({ | ||
| publicKey: 'publicKey', | ||
| publicKyberKey: 'publicKeyberKey', | ||
| user: { uuid: 'exampleUuid', email }, | ||
| }); | ||
| }); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make this parameter optional for now. Wdyt? @sg-gs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as long as the backend is not offering it for sure we need to reflect the reality of the types