[_]: fix/negative amount when calculating taxes #325
Merged
+72
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sg-gs
reviewed
Nov 25, 2025
| }); | ||
| }); | ||
|
|
||
| test('When the user provides a promo code with a discount that is more than the product price, then the price should be 0 instead of a negative price', async () => { |
Member
There was a problem hiding this comment.
To not block you know, I will leave it as a suggestion: if the controller allows it (because it is valid), consider handling these things at the business case level the next time (services/domains).
Collaborator
Author
There was a problem hiding this comment.
I'll keep that in mind. Thanks for the feedback! 🙌🏽
sg-gs
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a coupon discount exceeds the product’s original price, we must calculate taxes based on €0 instead of the resulting negative amount. Stripe rejects negative prices, so adjusting the taxable amount to zero prevents errors.