Skip to content

Add eslint join logs #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dajimenezriv-internxt merged 4 commits into from
Apr 16, 2025
Merged

Add eslint join logs #157

dajimenezriv-internxt merged 4 commits into from
Apr 16, 2025

Conversation

@dajimenezriv-internxt
Copy link
Contributor

@dajimenezriv-internxt dajimenezriv-internxt commented Apr 16, 2025

What

  1. Add eslint to the node-win project and also to the pipeline.
  2. Accept a logger object into the constructor params in VirtualDrive so that we use the logger from drive-desktop and we have the logs together.

@dajimenezriv-internxt dajimenezriv-internxt self-assigned this Apr 16, 2025
@dajimenezriv-internxt dajimenezriv-internxt merged commit 621dd66 into master Apr 16, 2025
2 checks passed
@dajimenezriv-internxt dajimenezriv-internxt deleted the add-eslint-join-logs branch April 16, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ArceDanielShok ArceDanielShok ArceDanielShok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dajimenezriv-internxt dajimenezriv-internxt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dajimenezriv-internxt @ArceDanielShok