Skip to content

Conversation

@ArceDanielShok
Copy link
Contributor

This Pull Request introduces two important improvements related to code structure and file path handling on Windows.

  • Refactor Properties in Methods:
    • All methods have been refactored to receive properties as an object instead of individual parameters. This improves code readability, reduces the possibility of errors when modifying method signatures, and facilitates the addition of new properties in the future.
  • Solution for Special Characters in File Paths (Windows):
    • A solution has been implemented for the correct handling of special characters in file paths on Windows. The previous issue was that the handleForPath function was converting the wide string path to a UTF-8 string and using that for file operations, which could cause issues with special characters. Windows APIs should use wide strings directly for proper Unicode support.
    • Steps to fix:
      • Removed the conversion from wide string to regular string.
      • Using wide string versions of filesystem functions.
      • Using CreateFileW instead of CreateFile with the wide string path.
      • Ensured proper error handling for wide strings (in PlaceHolderInfo.cpp).

@ArceDanielShok ArceDanielShok self-assigned this Apr 15, 2025
@dajimenezriv-internxt dajimenezriv-internxt merged commit d7b5cf0 into master Apr 16, 2025
2 checks passed
@dajimenezriv-internxt dajimenezriv-internxt deleted the refactor-method branch April 16, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants