Skip to content

Conversation

@apsantiso
Copy link
Contributor

@apsantiso apsantiso commented Sep 13, 2025

Changes

  • Include room and roomUser inside the calls module as they belong to the same bounded context. Creating a separated module for rooms when rooms do not exists outside of the context of a call does not make sense. The call module was highly coupled to the rooms module without any domain.
  • Reduced try/catch usage inside the usecases, we can log any unexpected error using a httpExceptionFilter
  • Error handling logic is moved to the controllers / infrastructure layer unless needed (it is not a must to leave the logger in the infra, at least for me)

What does this PR does not change / looks for?

  • Unit tests are fixed to go according the new structure, however, this does not looks to fix bad tests cases. If there's some test that needs to be refactored / re-implemented (there are some of them), let's do it in another time.
  • The main logic does not change, any previous bug or behavior still remains, this is just some preparation so we can fix/implement features smoothly
  • We do not want to be dogmatic and apply every DDD/clean architecture definition, this PR only reduces some of the not required coupling.

@apsantiso apsantiso self-assigned this Sep 14, 2025
@apsantiso apsantiso requested review from CandelR and removed request for CandelR September 14, 2025 05:05
@apsantiso apsantiso merged commit 04950e0 into master Sep 14, 2025
3 of 5 checks passed
@apsantiso apsantiso deleted the refactor/restructure-folders-and-modules branch September 14, 2025 05:13
@apsantiso apsantiso requested a review from CandelR September 14, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants